-
Notifications
You must be signed in to change notification settings - Fork 29
Release 24.11.1 #8188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 24.11.1 #8188
Conversation
WalkthroughThe changes in this pull request include updates to the changelog and migration guides for version 24.11.1, released on November 13, 2024. New features introduced are the ability to add metadata to annotations for Trees and Segments, a summary row in the time tracking overview, and enhanced slider functionality. Additionally, several bug fixes and improvements have been made, including increased loading speeds for precomputed meshes and unified terminology in the UI. The migration guides have been updated to reflect these changes, including new Postgres evolution scripts. Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
CHANGELOG.released.md (1)
24-24
: Consider adding more context to the bug fix descriptionThe bug fix description "Fixed that zarr streaming version 3 returned the shape of mag (1, 1, 1) / the finest mag for all mags" could benefit from additional context about the impact and resolution.
Consider expanding it to:
- Fixed a bug that zarr streaming version 3 returned the shape of mag (1, 1, 1) / the finest mag for all mags. [#8116] + Fixed a bug where zarr streaming version 3 incorrectly returned the shape of the finest magnification (1, 1, 1) for all magnification levels, which caused rendering issues. The correct magnification-specific shapes are now returned. [#8116]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
CHANGELOG.released.md
(1 hunks)CHANGELOG.unreleased.md
(1 hunks)MIGRATIONS.released.md
(1 hunks)MIGRATIONS.unreleased.md
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- MIGRATIONS.unreleased.md
🧰 Additional context used
🪛 Markdownlint
MIGRATIONS.released.md
12-12: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
🔇 Additional comments (6)
CHANGELOG.unreleased.md (1)
Line range hint 13-23
: LGTM! Changelog properly cleared for next release.
The changelog has been correctly cleared of all previous entries (which are now part of 24.11.1), while maintaining the standard sections for future unreleased changes. This follows changelog best practices.
MIGRATIONS.released.md (3)
9-10
: LGTM: Release section header is properly formatted.
The new release section follows the established format and correctly documents version 24.11.1 with its release date.
11-11
: LGTM: Commits link uses correct version range.
The link correctly compares version 24.10.0 to 24.11.1, which is consistent with skipping version 24.11.0.
12-16
: Verify the existence and sequential order of evolution scripts.
The evolution scripts are properly listed and linked. Let's verify their existence and sequential ordering.
✅ Verification successful
Evolution scripts are correctly listed and ordered.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence and sequential order of the new evolution scripts.
# Test: Check if the evolution scripts exist and are in sequence
for script in 121-worker-name.sql 122-resolution-to-mag.sql 123-more-model-categories.sql; do
if ! [ -f "conf/evolutions/$script" ]; then
echo "Missing evolution script: $script"
fi
done
# Test: Check if there are any gaps in the sequence
ls -1 conf/evolutions/*.sql | sort -n | awk -F'-' '{print $1}' | uniq -c | awk '$1>1{print "Duplicate sequence number: " $2}'
Length of output: 6096
🧰 Tools
🪛 Markdownlint
12-12: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
CHANGELOG.released.md (2)
Line range hint 1-9
: LGTM: Well-structured changelog header
The header section follows best practices by clearly documenting:
- The purpose of the file
- Reference to unreleased changes
- The versioning scheme used (CalVer)
- Link to migration guide
10-54
: LGTM: Latest release entry follows standard format
The latest release entry (24.11.1) follows good changelog practices:
- Clear version number and release date
- Link to compare changes with previous version
- Changes organized into clear categories
- Each change references relevant PR numbers
|
||
## Unreleased | ||
[Commits](https://github.com/scalableminds/webknossos/compare/24.10.0...HEAD) | ||
[Commits](https://github.com/scalableminds/webknossos/compare/24.11.1...HEAD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Tag 24.11.1 Not Found
The specified tag "24.11.1" does not exist in the repository. Please ensure the tag is created before updating the comparison URL.
🔗 Analysis chain
LGTM! Version reference correctly updated.
The comparison URL has been properly updated to reference version 24.11.1, which aligns with the PR objective of releasing this version.
Let's verify the version reference:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the version tag exists and matches our changelog
# Expected: The tag should exist in the repository
git fetch --tags
git tag | grep "24.11.1" || echo "Tag 24.11.1 not found"
Length of output: 4866
We are skipping 24.11.0 to include a number of bugfixes.
Summary by CodeRabbit
Release Notes for Version 24.11.1
New Features
Bug Fixes