Fix dataset deletion error because of wrong SQL parsing #8639
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis change updates two SQL queries in the Changes
Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
frcroth
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
app/models/dataset/Dataset.scala (2)
825-830: Verify explicit SELECT and qualify columnsThe updated
findPathsForDatasetAndDatalayerquery now explicitly lists all fields matching theDataSourceMagRowcase class in the correct order. To avoid ambiguity and improve readability, consider using table aliases and qualifying columns. Also, verify that an index exists ondataset_mags.pathto maintain query performance.- SELECT _dataset, dataLayerName, mag, path, realPath, hasLocalData, _organization, directoryName - FROM webknossos.dataset_mags - INNER JOIN webknossos.datasets ON webknossos.dataset_mags._dataset = webknossos.datasets._id + SELECT dm._dataset, dm.dataLayerName, dm.mag, dm.path, dm.realPath, dm.hasLocalData, ds._organization, ds.directoryName + FROM webknossos.dataset_mags dm + INNER JOIN webknossos.datasets ds ON dm._dataset = ds._id
835-840: Apply explicit SELECT and qualification consistentlyIn
findAllByRealPath, the explicit column list is correct. For consistency and clarity, apply the same aliasing strategy:val dm = webknossos.dataset_mags.baseTableRow val ds = webknossos.datasets.baseTableRow run(sql""" SELECT dm._dataset, dm.dataLayerName, dm.mag, dm.path, dm.realPath, dm.hasLocalData, ds._organization, ds.directoryName FROM $dm INNER JOIN $ds ON dm._dataset = ds._id WHERE dm.realPath = $realPath """.as[DataSourceMagRow])Additionally, ensure there's an index on
dataset_mags.realPathto avoid full table scans.CHANGELOG.unreleased.md (1)
39-39: Nit: Improve changelog entry clarityThe entry:
- Fixed that deletion of dataset would lead to an error. [#8639]For readability and grammar, consider:
- Fixed that deletion of dataset would lead to an error. [#8639] + Fixed error when deleting a dataset. [#8639]This adds the missing article and aligns with the project's changelog style.
Regression introduced by #8609
Steps to test: