Add e2e test for dataset paths

[frcroth]

E2E test for the datasource/.../paths route, regression test for #8639

Path and Realpath are volatile so that I can run the tests with the same results locally. When running "yarn refresh-e2e-tests" I get my personal path in there, making the results different for the runner.

[coderabbitai]

Warning

Rate limit exceeded

@frcroth has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 49 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 17d40f1 and 91332a9.

📒 Files selected for processing (1)

• frontend/javascripts/test/backend-snapshot-tests/datasets.e2e.ts (1 hunks)

📝 Walkthrough

Walkthrough

A new end-to-end test case was added to the dataset API test suite. This test fetches dataset paths from a specific API endpoint, processes the response by relativizing certain path fields, and then compares the modified response to a stored snapshot.

Changes

File(s)	Change Summary
frontend/javascripts/test/backend-snapshot-tests/datasets.e2e.ts	Added a new E2E test "Dataset Paths" to fetch, process, and snapshot dataset path API responses.

Possibly related PRs

• Add dataset upload test (without using frontend) #8184: Adds an end-to-end test for dataset upload functionality in the same test file, focusing on a different API endpoint.

Suggested reviewers

• fm3

Poem

In the warren of code, a new test appears,
Fetching dataset paths, allaying our fears.
Paths are made stable, with snapshots in tow,
Ensuring our magLinks are ready to go!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[fm3]

Cool, thanks! Please have a look at the problem of the absolute path

[fm3]

Now that both paths are completely hidden, the test seems a little empty. It would have caught #8639 so I’d say it’s worth having and merging it, but I wonder if we could test the actual symlink resolving somehow, while still dropping anything up to binaryData from the paths in the snapshot 🤔 But #8384 and related are certainly more important right now, so let’s not spend any time on this now.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a50928d and d5c1065.

⛔ Files ignored due to path filters (1)

• frontend/javascripts/test/backend-snapshot-tests/__snapshots__/datasets.e2e.ts.snap is excluded by !**/*.snap

📒 Files selected for processing (1)

• frontend/javascripts/test/backend-snapshot-tests/datasets.e2e.ts (1 hunks)

🧰 Additional context used

🪛 GitHub Check: frontend-tests

frontend/javascripts/test/backend-snapshot-tests/datasets.e2e.ts

[failure] 151-151:
Parameter 'magLink' implicitly has an 'any' type.

---

[failure] 150-150:
Parameter 'pathInfo' implicitly has an 'any' type.

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: build-smoketest-push
• GitHub Check: backend-tests