-
Notifications
You must be signed in to change notification settings - Fork 29
Allow export_tiff and render_animation jobs cross-orga for public datasets #8911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughRemoved organization-ownership checks from specific job endpoints in JobController, adjusted corresponding localization messages, and added an unreleased changelog entry noting that export_tiff and render_animation are now allowed for public datasets of other organizations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks (4 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
unreleased_changes/8911.md (1)
1-2
: Clarify scope and tighten phrasing; format job namesThe sentence is slightly awkward and misses the “public-only, multi-orga” scope and token-access caveat. Also, format job names with backticks for readability.
### Changed -- The webknossos-worker jobs export_tiff and render_animation are now allowed also for public datasets of other organizations. +- Allow running webknossos-worker jobs `export_tiff` and `render_animation` on public datasets owned by other organizations (multi-organization setups only). Access via sharing tokens is not included; see #7360. Fixes #8910.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
app/controllers/JobController.scala
(0 hunks)conf/messages
(0 hunks)unreleased_changes/8911.md
(1 hunks)
💤 Files with no reviewable changes (2)
- app/controllers/JobController.scala
- conf/messages
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: backend-tests
- GitHub Check: frontend-tests
- GitHub Check: build-smoketest-push
Steps to test:
Issues:
$PR_NUMBER.md
file inunreleased_changes
or use./tools/create-changelog-entry.py
)