Skip to content

Allow export_tiff and render_animation jobs cross-orga for public datasets #8911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2025
Merged

Allow export_tiff and render_animation jobs cross-orga for public datasets #8911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae93134
Allow export_tiff and render_animation jobs cross-orga for public dat…
fm3 Sep 10, 2025
3cfe6f4
changelog
fm3 Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/controllers/JobController.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,6 @@ class JobController @Inject()(jobDAO: JobDAO,
organization <- organizationDAO.findOne(dataset._organization)(GlobalAccessContext) ?~> Messages(
"organization.notFound",
dataset._organization)
_ <- Fox.fromBool(request.identity._organization == organization._id) ?~> "job.exportTiff.notAllowed.organization" ~> FORBIDDEN
_ <- Fox.runOptional(layerName)(datasetService.assertValidLayerNameLax)
_ <- Fox.runOptional(annotationLayerName)(datasetService.assertValidLayerNameLax)
_ <- jobService.assertBoundingBoxLimits(bbox, mag)
Expand Down Expand Up @@ -496,7 +495,6 @@ class JobController @Inject()(jobDAO: JobDAO,
organization <- organizationDAO.findOne(dataset._organization)(GlobalAccessContext) ?~> Messages(
"organization.notFound",
dataset._organization)
_ <- Fox.fromBool(request.identity._organization == organization._id) ?~> "job.renderAnimation.notAllowed.organization" ~> FORBIDDEN
userOrganization <- organizationDAO.findOne(request.identity._organization)
animationJobOptions = request.body
_ <- Fox.runIf(!PricingPlan.isPaidPlan(userOrganization.pricingPlan)) {
Expand Down
2 changes: 0 additions & 2 deletions conf/messages
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,13 +344,11 @@ job.inferNeurons.notAllowed.organization = Currently neuron inferral is only all
job.inferNeurons.annotationIdEvalParamsMissing=A evaluation of the neuron inferral jobs was requested but no annotation was supplied.
job.inferMitochondria.notAllowed.onlySuperUsers=Currently mitochondria inferral is only allowed for super users.
job.meshFile.notAllowed.organization = Calculating mesh files is only allowed for datasets of your own organization.
job.exportTiff.notAllowed.organization=Exporting tiff files is only allowed for datasets of your own organization.
job.segmentIndexFile.notAllowed.organization = Calculating segment index files is only allowed for datasets of your own organization.
job.globalizeFloodfill.notAllowed.organization = Globalizing floodfills is only allowed for datasets of your own organization.
job.materializeVolumeAnnotation.notAllowed.organization = Materializing volume annotations is only allowed for datasets of your own organization.
job.noWorkerForDatastoreAndJob = No webknossos-worker supporting the requested job is available for the selected datastore.
job.emailNotifactionsDisabled = Email notifications are not enabled for this job type.
job.renderAnimation.notAllowed.organization = Rendering animations is only allowed for datasets of your own organization.
job.alignSections.notAllowed.organization = Aligning sections is only allowed for datasets of your own organization.
job.additionalCoordinates.invalid = The passed additional coordinates are invalid.
job.trainModel.notAllowed.organization = Training AI models is only allowed for datasets of your own organization.
Expand Down
2 changes: 2 additions & 0 deletions unreleased_changes/8911.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
### Changed
- The webknossos-worker jobs export_tiff and render_animation are now allowed also for public datasets of other organizations.
Loading