refactor: more API/naming work #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
force-pushed
the
refactor/more-api-naming
branch
from
4d5be91 to
0b98335
Compare
akinomyoga
reviewed
Aug 6, 2023
Co-authored-by: Koichi Murase <[email protected]>
Not complex enough to warrant a separate function, and usages are adjacent.
Co-authored-by: Koichi Murase <[email protected]>
Co-authored-by: Koichi Murase <[email protected]>
akinomyoga
force-pushed
the
refactor/more-api-naming
branch
from
f89c328 to
d0695d0
Compare
Bash < 4.4 has a bug that all the elements are connected with
`${v+"$@"}` when IFS does not contain whitespaces. This becomes
problem with `${dict_options+"${dict_options[@]}"}`. One way to fix
it is to set IFS=$' \t\n'. In this patch, we instead change the use
of the array so that we do not have to rely on the ${v+"$@"} pattern.
|
rebased & squashed |
akinomyoga
approved these changes
Aug 12, 2023
|
Sweet, thanks! |
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
Sep 18, 2023
This is a regression in scop#1025. Reference: scop@f92ef41#diff-ea186058eaccb2fe1f557ed71d7cf58a9220a37ed3ab7fae9d2b0c99e48029deR11
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
Sep 23, 2023
This is a regression in scop#1025. Reference: scop@f92ef41#diff-ea186058eaccb2fe1f557ed71d7cf58a9220a37ed3ab7fae9d2b0c99e48029deR11
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
Sep 23, 2023
This is a regression in scop#1025. Reference: scop@f92ef41#diff-ea186058eaccb2fe1f557ed71d7cf58a9220a37ed3ab7fae9d2b0c99e48029deR11
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
Sep 25, 2023
This is a regression in scop#1025. Reference: scop@f92ef41#diff-ea186058eaccb2fe1f557ed71d7cf58a9220a37ed3ab7fae9d2b0c99e48029deR11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.