feat(xrandr): comma separated --setmonitor third argument

[scop]

Requires/stacks on top of #1025, drafting until that one is merged.

[akinomyoga]

Requires/stacks on top of #1025,

It seems most of the comments I made here should have been put in PR #1025. Sorry for the noise, but could you apply these to PR #1026?

[scop]

Requires/stacks on top of #1025,

It seems most of the comments I made here should have been put in PR #1025. Sorry for the noise, but could you apply these to PR #1026?

Hmm, #1026 is this one, and #1025 was merged an hour or so, without the suggestions that are still open here. I've rebased this on top of master, reducing it to just the xrandr changes it should have contained in the first place.

Some of the suggestions were moved over to #1028, but the ones still open here are not in master nor #1028. They don't really belong here, should they be moved to #1028 instead? At least they're related.

[akinomyoga]

Thanks. I'll move them to #1028 with the approach of -U var.

These (and #1028) are related to the variable name conflicts with nested generators. There are two solutions:

1. One is to use the local _tmp=$tmp; _comp_unlocal tmp; _comp_compgen ... '$_tmp' pattern, but it is tedious to write them every time and it doesn't still solve the problem perfectly as it can still conflict with underscored variables in the function _comp_compgen itself.
2. The other is -U var in fix(_comp_compgen_*): avoid conflicts with "-v var" #1028

After scanning the codebase, I'm currently leaning to option 2, i.e., adding -U var in _comp_compgen as in the added commits of #1028.

[akinomyoga]

Hmm, #1026 is this one, and #1025 was merged an hour or so

Ah, sorry. That is a typo of #1025.

[scop]

SGTM. I have noticed #1028 and related changes across. It's however something that I'd like to understand better than what I can immediately pick up from a casual skimming review, that's why I haven't commented on that stuff yet. But with the limited understanding I have at the moment, the -U approach gives me a better feeling.

[akinomyoga]

Thank you. You may already notice it, but doc/api-and-naming.md of #1028 is the description for the option -U.