Turn off antialias #502
Merged
Turn off antialias #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be clear, only the bounding-box edges are pixely: |
adroitwhiz
reviewed
Aug 28, 2019
Co-Authored-By: adroitwhiz <[email protected]>
|
This goes a bit deeper than I thought. Looking at the Chromium bug which this is intended to work around, it appears that the problem's root cause is a bug in the code for CMAA, a form of morphological antialiasing. Morphological antialiasing is essentially a post-processing filter run on the final render, and intended for 3D scenes. Because WebGL antialiasing is vendor-specific, certain platforms may be running their own vendor and platform-specific post-processing filters on the stage when antialiasing is enabled! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #500
Also, antialias isn't supported on all browsers, so this should make behavior more consistent. The downside is that vectors will have pixely edges, especially on lower density devices