Remove SvgRenderer.fromString call from SVGSkin.setSVG
#522
+28
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
force-pushed
the
remove-draw-fromsvg
branch
from
641c034 to
38e2676
Compare
adroitwhiz
changed the title
SvgRenderer._draw call from SVGSkin.setSVGSvgRenderer.fromString call from SVGSkin.setSVG
Merged
|
Closing in favor of #527 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on scratchfoundation/scratch-svg-renderer#107
Resolves
Resolves #518
Proposed Changes
This PR removes the call to
SVGSkin._svgRenderer.fromStringfrom theSVGSkin.loadSVGmethod, in the process updatingSVGSkinto use the new methods added in scratchfoundation/scratch-svg-renderer#107.Reason for Changes
Removing the
SVGSkin._svgRenderer.fromStringcall prevents the skin from being unnecessarily drawn twice (see #518 for more details).Updating
SVGSkinto use the newSvgRenderermethods makes the code much easier to reason about by removing unpredictable behavior (see this comment and scratchfoundation/scratch-svg-renderer#107 for more information).