Synchronous SVG mipmaps #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
force-pushed
the
svgmip-synchronous
branch
2 times, most recently
from
8bf0e75 to
af7eb6b
Compare
adroitwhiz
force-pushed
the
svgmip-synchronous
branch
from
af7eb6b to
bf5d666
Compare
|
I tested this out locally and it looked good. All tests are passing too. |
cwillisf
requested changes
Jan 7, 2020
There was a problem hiding this comment.
This is great! I just have one concern, commented below. What do you think, @adroitwhiz?
Co-Authored-By: Chris Willis-Ford <[email protected]>
|
Also, this is blocked on #534 |
This was referenced Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on scratchfoundation/scratch-svg-renderer#107.
Resolves
Resolves #518
Proposed Changes
This PR builds on @ktbee's excellent work on SVG mipmaps in #431.
When investigating #518, I discovered that once an SVG string is loaded into an
SvgRenderer, it can be drawn synchronously at any scale.The synchronous SVG-drawing method from scratchfoundation/scratch-svg-renderer#107 allows the SVG mipmap logic to be considerably simplified. No callbacks need to be passed around anywhere, much less state needs to be managed and kept track of, and the array of
SVGMIPs is now an array ofWebGLTextures.Reason for Changes
This considerably simplifies the state management logic of
SVGSkins.Reducing the complexity of
SVGSkins' logic will greatly ease the steps needed to fix #427.