Fix SVGSkin silhouettes #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fsih is this a hotfix candidate? |
|
Yes, we'll review this for hotfix and hopefully get it in early next week |
|
It's in! Thanks again for the quick fix @adroitwhiz ! |
|
Sorry for breaking it in the first place! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #543
Proposed Changes
This PR implements
updateSilhouetteforSVGSkins, so that even if anSVGSkinhas never been rendered, its silhouette still exists.This PR also adds a new helper function,
_getDrawableScreenSpaceScale, toRenderWebGL. This function's result is now passed toSkin.updateSilhouetteso that the skin's silhouette can be properly scaled.Reason for Changes
This resolves the aforementioned bug, first reported on the Bugs and Glitches forum.
Test Coverage
Incoming...