Description
As a follow-up to #544, I'm considering moving SVG skin silhouette creation into updateSilhouette
. To ensure this doesn't cause any breakage, we need to ensure the issue in #398 has been fixed.
Here are all the call sites of Drawable.isTouching
, as far as I can tell:
isTouchingColor
andisTouchingDrawables
call_candidatesTouching
, which callsupdateSilhouette
on all "candidate" drawables' skins. However, they do not appear to callupdateSilhouette
on the passed drawable's skin.drawableTouching
andpick
both callupdateSilhouette
._getConvexHullPointsForDrawable
callsdrawable.skin.isTouchingLinear
directly, and does not callupdateSilhouette
.
It may also be fruitful to investigate whether we can throw an error inside isTouching
if the silhouette is "dirty" without the extra check slowing things down.
Metadata
Metadata
Assignees
Labels
No labels