Update drawables' matrix + silhouette in _getConvexHullPointsForDrawable #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves scratchfoundation/scratch-gui#5647
Resolves #546
Proposed Changes
This PR adds calls to
updateMatrixandupdateSilhouetteinsideRenderWebGL._getConvexHullPointsForDrawable.Reason for Changes
Text bubbles are positioned according to the convex hull of their sprite's current costume/skin. Generating convex hulls requires the sprite's drawable to have an up-to-date inverse matrix and its skin to have an up-to-date silhouette.
If those attributes are not up-to-date, the convex hull will not be properly generated, and speech bubbles will be incorrectly positioned. See also scratchfoundation/scratch-gui#4344 for a previous instance of this happening.
These changes are also included in #555, but that PR is much larger in scope so it may be easier to review this one.