fix: rename batch id to hash in block_trace and block_hash tables
#93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`id` to `hash` in `block_hash` table. And update query APIs.
colinlyguo
previously approved these changes
Feb 20, 2023
silathdiir
changed the title
id to hash in block_trace and block_hash tablesid to hash in block_trace and block_hash tables
colinlyguo
approved these changes
Feb 22, 2023
|
cc @zzq0826 ? |
0xmountaintop
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scoll PR scroll-tech/scroll#305 has been merged.
No need to update frontend. Since the batch
hashis also returned in batchid(as before).Summary
idtohashinblock_hashtable.batch_idtobatch_hashinblock_tracetable.test.sqlfor local test.