feat(relayer): update the watcher and relayer based on the new contract #305

icemelon · 2023-02-20T22:01:27Z

Purpose or design rationale of this PR

The original commit history is from PR Relayer changes scrollchain #296. Because the previous PR is built on top of the bridge contract PR, which is now merged to alpha branch, I reset the pending changes against the latest alpha.

The features and changes introduced in this PR include:
- update the event signatures based on the latest bridge contract
- add the gas oracle relaying to the L1 relayer and add an additional L1 block table to the DB
- change the batch proposing and commitment logic. previously the commit tx is initialized by the L2 relayer, but now done by batch proposer
- rename the batch ID to batch hash and update the hash calculation method based on the new contract design
- change the DB table schema with regard to the batch hash
Does this PR involve a new deployment, and involve a new git tag & docker image tag? If so, has tag in common/version.go been updated?
TBD
Is this PR a breaking change? If so, have it been attached a breaking-change label?
Yes.

ChuhanJin · 2023-02-21T02:15:13Z

ChuhanJin · 2023-02-21T02:41:37Z

ChuhanJin · 2023-02-21T02:53:11Z

ChuhanJin · 2023-02-21T03:02:42Z

ChuhanJin · 2023-02-21T03:12:02Z

Jenkinsfile

bridge/l2/backend.go

ChuhanJin · 2023-02-22T06:23:26Z

ChuhanJin · 2023-02-22T06:35:11Z

…riceOracle

ChuhanJin · 2023-02-22T07:13:23Z

ChuhanJin · 2023-02-22T07:50:55Z

ChuhanJin · 2023-02-22T08:16:24Z

0xmountaintop · 2023-02-22T08:26:23Z

we should update common/version/version.go

ChuhanJin · 2023-02-22T08:44:04Z

ChuhanJin · 2023-02-22T08:52:53Z

Co-authored-by: colinlyguo <[email protected]> Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> refactor(bridge): remove layer1 client in in layer1 relayer constructor (#274) Co-authored-by: vincent <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> fix: add gas multiplier (#275) feat(libzkp): use dylib instead of staticlib (#266) Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: colin <[email protected]> Co-authored-by: colinlyguo <[email protected]> Revert "fix: add gas multiplier (#275)" (#279) build: add nightly-2022-12-10 rust-related builder image (#282) fix(bridge): compatible with DynamicFeeTxType not supported chain (#280) Co-authored-by: colinlyguo <[email protected]> feat(contract): enable whitelist relayer (#272) Co-authored-by: Péter Garamvölgyi <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> perf(bridge): execute relayer loops independently (#258) Co-authored-by: colin <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> feat(bridge): confirm block based on "safe" and "finalized" tags (#265) feat: allow to override L2 deployment when address is provided (#293) feat(contracts): Add fee vault (#223) feat(confirmations): Upgrade confirm (#291) feat(coordinator): Enable set ws compression level. (#292) feat(roller&coordinator): upgrade lizkp to zkevm-0215 version (#281) Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: xinran chen <[email protected]> Co-authored-by: Ubuntu <[email protected]> build: update version to `alpha-v1.0` (#301) feat: import genesis batch during startup (#299) Co-authored-by: HAOYUatHZ <[email protected]> feat(contracts): new bridge contracts (#288) Co-authored-by: Haichen Shen <[email protected]> Co-authored-by: Thegaram <[email protected]> Co-authored-by: colin <[email protected]> chore: upgrade l2geth dependency for trace type (#304) feat(bridge): update the watcher and relayer based on the new contract (#305) Co-authored-by: colinlyguo <[email protected]> Co-authored-by: zimpha <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> fix incorrect block order during batch recovery (#311) fix(bridge): fix batch proposer (#312) Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> fix: Flush buffered writer (#314) fix(config): fix typos (#315) feat(bridge): only update gas price oracle for exceeding diff threshold (#319) fix(bridge): fix typos (#321) feat(batch proposer): add time limit to commit batches (#323) fix(db): fix `SetMaxOpenConns` (#328) Fix(zkevm): fix zkevm bug for goerli. (#334) fix(build): jenkinsfile tag job optimized and fix (#331) Co-authored-by: vincent <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> fix: reduce finalize batch tx frequency (#332) alpha inegration with multibin fix makefile fix lint fix lint try fix commit op fix lint goimports trigger ci bugfix(libzkp): fix difficulty (#343) fix(contract): forbid to call message queue and l2 messenger from l1 (#341) Co-authored-by: HAOYUatHZ <[email protected]> fix(roller): fix stack bug (#320) Co-authored-by: HAOYUatHZ <[email protected]>

icemelon added the breaking-change label Feb 20, 2023

icemelon mentioned this pull request Feb 20, 2023

Relayer changes scrollchain #296

Closed

colinlyguo force-pushed the feat/update-relayer-for-new-contract branch 2 times, most recently from da321e8 to 33e2b6c Compare February 21, 2023 00:43

icemelon changed the title ~~apply all relayer changes to latest alpha branch~~ Update the watcher and relayer to the latest contract Feb 21, 2023

icemelon changed the title ~~Update the watcher and relayer to the latest contract~~ Update the watcher and relayer based on the new contract Feb 21, 2023

icemelon changed the title ~~Update the watcher and relayer based on the new contract~~ feat(relayer): update the watcher and relayer based on the new contract Feb 21, 2023

icemelon and others added 8 commits February 20, 2023 19:06

apply all relayer changes to latest alpha branch

ebcf120

trigger ci

30a5b6a

update txID hash

35cf194

refine the batch proposer send tx

d494369

trigger ci

86e9026

update event watcher

0d40671

fix event watcher

b0b0920

fix typo

d663d05

icemelon force-pushed the feat/update-relayer-for-new-contract branch from 8c6ac25 to d663d05 Compare February 21, 2023 03:07

silathdiir mentioned this pull request Feb 21, 2023

fix: rename batch id to hash in block_trace and block_hash tables scroll-tech/rollup-explorer-backend#93

Merged

0xmountaintop reviewed Feb 21, 2023

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

colinlyguo and others added 3 commits February 21, 2023 11:38

recover docker build test

2ea2175

trigger ci

62c9104

add more functions/events to mock bridge contracts

7985f2d

0xmountaintop reviewed Feb 21, 2023

View reviewed changes

bridge/l2/backend.go Outdated Show resolved Hide resolved

colinlyguo and others added 3 commits February 21, 2023 13:26

update GetBatchCalldataLengt

6465d1d

handle nil basefee case

eeff892

simplify the genesis batch creation

7b70ae7

fix CI

aa8e87d

Thegaram previously approved these changes Feb 22, 2023

View reviewed changes

colinlyguo previously approved these changes Feb 22, 2023

View reviewed changes

add todos and parallelize l1 relayer ProcessSavedEvents & ProcessGasP…

85e26c0

…riceOracle

colinlyguo dismissed stale reviews from Thegaram and themself via 85e26c0 February 22, 2023 06:54

trigger ci

cf40468

colinlyguo previously approved these changes Feb 22, 2023

View reviewed changes

add batchDataBufferSizeLimit

f8e52d7

colinlyguo dismissed their stale review via f8e52d7 February 22, 2023 07:35

fix assume in fuzzing tests

44f1d0b

colinlyguo force-pushed the feat/update-relayer-for-new-contract branch from d685b22 to 44f1d0b Compare February 22, 2023 08:08

Thegaram previously approved these changes Feb 22, 2023

View reviewed changes

bump version && decrease loop time && parallelize l1 watcher event

eaf1e84

colinlyguo dismissed Thegaram’s stale review via eaf1e84 February 22, 2023 08:36

trigger ci

219bb82

Thegaram approved these changes Feb 22, 2023

View reviewed changes

colinlyguo approved these changes Feb 22, 2023

View reviewed changes

0xmountaintop approved these changes Feb 22, 2023

View reviewed changes

0xmountaintop merged commit fb7002b into alpha Feb 22, 2023

0xmountaintop deleted the feat/update-relayer-for-new-contract branch February 22, 2023 10:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(relayer): update the watcher and relayer based on the new contract #305

feat(relayer): update the watcher and relayer based on the new contract #305

Uh oh!

icemelon commented Feb 20, 2023 •

edited

Loading

Uh oh!

ChuhanJin commented Feb 21, 2023

Uh oh!

ChuhanJin commented Feb 21, 2023

Uh oh!

ChuhanJin commented Feb 21, 2023

Uh oh!

ChuhanJin commented Feb 21, 2023

Uh oh!

ChuhanJin commented Feb 21, 2023

Uh oh!

Uh oh!

Uh oh!

ChuhanJin commented Feb 22, 2023

Uh oh!

ChuhanJin commented Feb 22, 2023

Uh oh!

ChuhanJin commented Feb 22, 2023

Uh oh!

ChuhanJin commented Feb 22, 2023

Uh oh!

ChuhanJin commented Feb 22, 2023

Uh oh!

0xmountaintop commented Feb 22, 2023

Uh oh!

ChuhanJin commented Feb 22, 2023

Uh oh!

ChuhanJin commented Feb 22, 2023

Uh oh!

Uh oh!

feat(relayer): update the watcher and relayer based on the new contract #305

feat(relayer): update the watcher and relayer based on the new contract #305

Uh oh!

Conversation

icemelon commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChuhanJin commented Feb 21, 2023

Uh oh!

ChuhanJin commented Feb 21, 2023

Uh oh!

ChuhanJin commented Feb 21, 2023

Uh oh!

ChuhanJin commented Feb 21, 2023

Uh oh!

ChuhanJin commented Feb 21, 2023

Uh oh!

Uh oh!

Uh oh!

ChuhanJin commented Feb 22, 2023

Uh oh!

ChuhanJin commented Feb 22, 2023

Uh oh!

ChuhanJin commented Feb 22, 2023

Uh oh!

ChuhanJin commented Feb 22, 2023

Uh oh!

ChuhanJin commented Feb 22, 2023

Uh oh!

0xmountaintop commented Feb 22, 2023

Uh oh!

ChuhanJin commented Feb 22, 2023

Uh oh!

ChuhanJin commented Feb 22, 2023

Uh oh!

Uh oh!

icemelon commented Feb 20, 2023 •

edited

Loading