Skip to content

Spanish Translation and English Scroll Docs Fixes #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

ManuGodzilla
Copy link
Contributor

Closing issues

closes #81

Description

Translation of english Scroll documents into spanish and correction of errors in english Scroll pages.

Changes

  • Created the \src\content\docs\es Directory.
  • Created the \public\locales\es\translation.json Directory
  • We translated the Whatsnext button and the right side title such as "On this page", "More", "Edit this Page", "Join into our Community" and "Feedback"
  • During the Translation, we found a bug at src\components\RightSidebar\TableOfContents\index.tsx, the right side bar title " On This Page" it disappear, even when we follow the exact command to implemented into spanish. We think it's a rendering code error out of this scope that should be addressed by other PR.

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for scroll-documentation failed.

Name Link
🔨 Latest commit 2bf810d
🔍 Latest deploy log https://app.netlify.com/sites/scroll-documentation/deploys/650c96b69560e50008a37758

@dghelm dghelm requested a review from zzq0826 September 5, 2023 13:30
@dghelm
Copy link
Contributor

dghelm commented Sep 5, 2023

During the Translation, we found a bug at src\components\RightSidebar\TableOfContents\index.tsx, the right side bar title " On This Page" it disappear, even when we follow the exact command to implemented into spanish. We think it's a rendering code error out of this scope that should be addressed by other PR.

@zzq0826 might have an idea for what's happening here.

@dghelm dghelm requested a review from Turupawn September 5, 2023 13:32
@zzq0826
Copy link
Member

zzq0826 commented Sep 11, 2023

During the Translation, we found a bug at src\components\RightSidebar\TableOfContents\index.tsx, the right side bar title " On This Page" it disappear, even when we follow the exact command to implemented into spanish. We think it's a rendering code error out of this scope that should be addressed by other PR.

@zzq0826 might have an idea for what's happening here.

@dghelm @ManuGodzilla Fixed this issue here. There was a problem with the CSR earlier. (Need to rebase the develop branch to make it work here).

Copy link
Member

@Turupawn Turupawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observaciones sobre "Contruyendo en Scroll"

@Turupawn
Copy link
Member

Closing this and moving it to #95 due to conflicts with this branch

@Turupawn Turupawn closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Translation to Spanish and English fixes in Docs
4 participants