Skip to content

Spanish Translation and English Scroll Docs Fixes (Remake) #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 29, 2023

Conversation

Turupawn
Copy link
Member

Continuation of #82 by @ManuGodzilla , we are dropping the last version do to too many conflicts. This PR is a cleaner version updated with the latest changes

Closing issues

closes #81

Description

Translation of english Scroll documents into spanish and correction of errors in english Scroll pages.

Changes

  • Created the \src\content\docs\es Directory.
  • Created the \public\locales\es\translation.json Directory
  • We translated the Whatsnext button and the right side title such as "On this page", "More", "Edit this Page", "Join into our Community", "Feedback" and "Read More"

@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for scroll-documentation ready!

Name Link
🔨 Latest commit a7a34b7
🔍 Latest deploy log https://app.netlify.com/sites/scroll-documentation/deploys/65173a57b1e8700008acbdc8
😎 Deploy Preview https://deploy-preview-95.docs.scroll.xyz/es/glossary
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dghelm
Copy link
Contributor

dghelm commented Sep 29, 2023

Follow-up:

  • Landing Page translation
  • Second Review by Juan and Chris

@dghelm dghelm merged commit 6d5b124 into scroll-tech:develop Sep 29, 2023
dghelm added a commit that referenced this pull request Oct 17, 2023
* Removed trailing slashes in the urls (#63)

Fix: faucet link broken because of the double slash

* Fix: What's next link on ERC721 bridge page

when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.

* Update: Add Bware Faucet (#64)

* add bware faucet

* fix dangling html close comment

* fix: apply new logo (#66)

* Rebranding (#69)

* Update: 8/23/23 (#65)

* Removed trailing slashes in the urls (#63)

Fix: faucet link broken because of the double slash

* Fix: What's next link on ERC721 bridge page

when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.

* Update: Add Bware Faucet (#64)

* add bware faucet

* fix dangling html close comment

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>

* fix: apply new logo (#67)

* update press link and change zero-knowledge to zero knowledge

---------

Co-authored-by: Daniel Helm <[email protected]>
Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>
Co-authored-by: Holybasil <[email protected]>

* Prod to develop fixing icons to resolve PRs to different branches (#72)

* Update: 8/23/23 (#65)

* Removed trailing slashes in the urls (#63)

Fix: faucet link broken because of the double slash

* Fix: What's next link on ERC721 bridge page

when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.

* Update: Add Bware Faucet (#64)

* add bware faucet

* fix dangling html close comment

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>

* fix: apply new logo (#67)

* fix: Apple touch icon 256x256 (#68)

* Update prod for rebrand. (#71)

* Removed trailing slashes in the urls (#63)

Fix: faucet link broken because of the double slash

* Fix: What's next link on ERC721 bridge page

when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.

* Update: Add Bware Faucet (#64)

* add bware faucet

* fix dangling html close comment

* fix: apply new logo (#66)

* Rebranding (#69)

* Update: 8/23/23 (#65)

* Removed trailing slashes in the urls (#63)

Fix: faucet link broken because of the double slash

* Fix: What's next link on ERC721 bridge page

when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.

* Update: Add Bware Faucet (#64)

* add bware faucet

* fix dangling html close comment

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>

* fix: apply new logo (#67)

* update press link and change zero-knowledge to zero knowledge

---------

Co-authored-by: Daniel Helm <[email protected]>
Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>
Co-authored-by: Holybasil <[email protected]>

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>
Co-authored-by: Holybasil <[email protected]>
Co-authored-by: zzq0826 <[email protected]>

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>
Co-authored-by: Holybasil <[email protected]>
Co-authored-by: zzq0826 <[email protected]>

* Update blocks.mdx (#76)

* Update erc721-nft-bridge.mdx (#78)

* Update helper.tsx (#75)

* Update/repo banner (#83)

* update: new banner

* add badges

* fix not translate in React Components inside Astro (#85)

* fixed broken links and fixed some whats-nexts (#87)

* fix spelling of "Merkle" (#91)

* Fixed wrong address (#90)

* Update bridge-erc20-through-the-custom-gateway.mdx

Fixed wrong address

* Update bridge-erc20-through-the-custom-gateway.mdx

* Update PureFooter.tsx (#84)

Open a new target URL in new tab, current its  overriding this page(main domain)

* Spanish Translation and English Scroll Docs Fixes (Remake) (#95)

* spanish bug fix

* redo previous fixes

* spanish grammar fix

* localization improvements on developers index page

* improvement proposals for some developers pages

* finished my Developer review

* improvements to user guide in spanish

* learn spanish translation review

* technology spanish translation review

* Glosary update

---------

Co-authored-by: ManuGodzilla <[email protected]>
Co-authored-by: axlvaz <[email protected]>

* Update verifying-smart-contracts.mdx (#101)

I just found this word spelling error

* feat: add technology/security section (#100)

* feat: add technology/security section

* update scope and firm ordering

* update Zellic reports

* fix critical price - missing 0

* add report

* clarify out-of-scope submissions

---------

Co-authored-by: Haichen Shen <[email protected]>

* Developer guides: Mainnet related updates (#102)

* initial network changes

* update for mainnet content

---------

Co-authored-by: Daniel Helm <[email protected]>

* update for mainnet content (#104)

* fixed foundry verification (#103)

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>
Co-authored-by: Holybasil <[email protected]>
Co-authored-by: zzq0826 <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: diposs <[email protected]>
Co-authored-by: ManuGodzilla <[email protected]>
Co-authored-by: Anton Livaja <[email protected]>
Co-authored-by: Ahmed Castro <[email protected]>
Co-authored-by: jrsurya <[email protected]>
Co-authored-by: axlvaz <[email protected]>
Co-authored-by: JohnsonSmile <[email protected]>
Co-authored-by: Haichen Shen <[email protected]>
dghelm added a commit that referenced this pull request Oct 17, 2023
* Removed trailing slashes in the urls (#63)

Fix: faucet link broken because of the double slash

* Fix: What's next link on ERC721 bridge page

when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.

* Update: Add Bware Faucet (#64)

* add bware faucet

* fix dangling html close comment

* fix: apply new logo (#66)

* Rebranding (#69)

* Update: 8/23/23 (#65)

* Removed trailing slashes in the urls (#63)

Fix: faucet link broken because of the double slash

* Fix: What's next link on ERC721 bridge page

when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.

* Update: Add Bware Faucet (#64)

* add bware faucet

* fix dangling html close comment

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>

* fix: apply new logo (#67)

* update press link and change zero-knowledge to zero knowledge

---------

Co-authored-by: Daniel Helm <[email protected]>
Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>
Co-authored-by: Holybasil <[email protected]>

* Prod to develop fixing icons to resolve PRs to different branches (#72)

* Update: 8/23/23 (#65)

* Removed trailing slashes in the urls (#63)

Fix: faucet link broken because of the double slash

* Fix: What's next link on ERC721 bridge page

when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.

* Update: Add Bware Faucet (#64)

* add bware faucet

* fix dangling html close comment

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>

* fix: apply new logo (#67)

* fix: Apple touch icon 256x256 (#68)

* Update prod for rebrand. (#71)

* Removed trailing slashes in the urls (#63)

Fix: faucet link broken because of the double slash

* Fix: What's next link on ERC721 bridge page

when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.

* Update: Add Bware Faucet (#64)

* add bware faucet

* fix dangling html close comment

* fix: apply new logo (#66)

* Rebranding (#69)

* Update: 8/23/23 (#65)

* Removed trailing slashes in the urls (#63)

Fix: faucet link broken because of the double slash

* Fix: What's next link on ERC721 bridge page

when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.

* Update: Add Bware Faucet (#64)

* add bware faucet

* fix dangling html close comment

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>

* fix: apply new logo (#67)

* update press link and change zero-knowledge to zero knowledge

---------

Co-authored-by: Daniel Helm <[email protected]>
Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>
Co-authored-by: Holybasil <[email protected]>

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>
Co-authored-by: Holybasil <[email protected]>
Co-authored-by: zzq0826 <[email protected]>

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>
Co-authored-by: Holybasil <[email protected]>
Co-authored-by: zzq0826 <[email protected]>

* Update blocks.mdx (#76)

* Update erc721-nft-bridge.mdx (#78)

* Update helper.tsx (#75)

* Update/repo banner (#83)

* update: new banner

* add badges

* fix not translate in React Components inside Astro (#85)

* fixed broken links and fixed some whats-nexts (#87)

* fix spelling of "Merkle" (#91)

* Fixed wrong address (#90)

* Update bridge-erc20-through-the-custom-gateway.mdx

Fixed wrong address

* Update bridge-erc20-through-the-custom-gateway.mdx

* Update PureFooter.tsx (#84)

Open a new target URL in new tab, current its  overriding this page(main domain)

* Spanish Translation and English Scroll Docs Fixes (Remake) (#95)

* spanish bug fix

* redo previous fixes

* spanish grammar fix

* localization improvements on developers index page

* improvement proposals for some developers pages

* finished my Developer review

* improvements to user guide in spanish

* learn spanish translation review

* technology spanish translation review

* Glosary update

---------

Co-authored-by: ManuGodzilla <[email protected]>
Co-authored-by: axlvaz <[email protected]>

* Update verifying-smart-contracts.mdx (#101)

I just found this word spelling error

* feat: add technology/security section (#100)

* feat: add technology/security section

* update scope and firm ordering

* update Zellic reports

* fix critical price - missing 0

* add report

* clarify out-of-scope submissions

---------

Co-authored-by: Haichen Shen <[email protected]>

* Developer guides: Mainnet related updates (#102)

* initial network changes

* update for mainnet content

---------

Co-authored-by: Daniel Helm <[email protected]>

* update for mainnet content (#104)

* fixed foundry verification (#103)

* Add bug bounty (#106)

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>
Co-authored-by: Holybasil <[email protected]>
Co-authored-by: zzq0826 <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: diposs <[email protected]>
Co-authored-by: ManuGodzilla <[email protected]>
Co-authored-by: Anton Livaja <[email protected]>
Co-authored-by: Ahmed Castro <[email protected]>
Co-authored-by: jrsurya <[email protected]>
Co-authored-by: axlvaz <[email protected]>
Co-authored-by: JohnsonSmile <[email protected]>
Co-authored-by: Haichen Shen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Translation to Spanish and English fixes in Docs
3 participants