-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add TLS 1.3 support (basic) #2146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems that most of the tests fail due to random errors in the TLS 1.3 automaton. You can fix the tests named
All ways are fine and mean "do not use the old cryptography module to perform TLS 1.3 tests". |
Codecov Report
@@ Coverage Diff @@
## master #2146 +/- ##
=========================================
- Coverage 87.36% 87% -0.37%
=========================================
Files 200 200
Lines 45454 45617 +163
=========================================
- Hits 39711 39687 -24
- Misses 5743 5930 +187
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR! I am glad that we will be able to include it in v2.4.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR thanks for your answers!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really awesome PR !
I only have one comment
301b2b2
to
2e0c306
Compare
This PR adds new TLS 1.3 messages and extensions and support only basic 1-RTT handshake :
TODO (next PRs) :