Add Buildkite Config #305
Merged
Add Buildkite Config #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
December 5, 2019 10:24
briemcnally
requested review from
CarlosMecha,
brennan and
SegmentDestinationsBot
CarlosMecha
reviewed
Dec 10, 2019
.buildkite/pipeline.yml
Outdated
| @@ -0,0 +1,44 @@ | |||
| env: | |||
| SEGMENT_CONTEXTS: "snyk,npm,aws-credentials,ecr,saucelabs" | |||
There was a problem hiding this comment.
I think we are going to need npm-publish (I think that's the name). It's a context with write access on NPM.
There was a problem hiding this comment.
@CarlosMecha I talked with tooling and updated the npm context to npm-publish so it has read and write access, as well as pass the NPM_TOKEN env var to the plugin as well in the publish step.
CarlosMecha
approved these changes
Dec 10, 2019
briemcnally
added a commit
that referenced
this pull request
Dec 10, 2019
This reverts commit ab2ec4d.
This was referenced Dec 10, 2019
Merged
patrickotoole
pushed a commit
to rockerbox/analytics.js-integrations
that referenced
this pull request
Feb 27, 2020
* Initial buildkite config * Test just build * Fix interpolation issue * Change docker image * Change dockerfile * Add user * Add buildkite tests * Fix user * Combine build and test * Add Synk test * Add saucelabs * Add publish step and remove comments * Remove circleci-enterprise * Change npm context for read/write access
marinhero
pushed a commit
to Wootric/analytics.js-integrations-1
that referenced
this pull request
Apr 24, 2020
* Initial buildkite config * Test just build * Fix interpolation issue * Change docker image * Change dockerfile * Add user * Add buildkite tests * Fix user * Combine build and test * Add Synk test * Add saucelabs * Add publish step and remove comments * Remove circleci-enterprise * Change npm context for read/write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Are there breaking changes in this PR?
No.
Any background context you want to provide?
Segment is migrating from Circle CI Enterprise to using Buildkite. We will maintain 2 CI workflows for a.js integrations. Buildkite will be used as our internal CI workflow. Our external CI flow for contractors will run on CirclCI cloud.
Is there parity with the server-side/android/iOS integration components (if applicable)?
N/A
Does this require a new integration setting? If so, please explain how the new setting works
N/A
Links to helpful docs and other external resources
* Buildkite User Guide
* Buildkite migration guide