Skip to content

Conversation

briemcnally
Copy link
Contributor

@briemcnally briemcnally commented Dec 10, 2019

Fixes publish step from #305. Adds docker image and npm auth login for publishing.

@briemcnally briemcnally requested a review from a team as a code owner December 10, 2019 21:10
@briemcnally briemcnally requested a review from gpsamson December 10, 2019 21:10
@briemcnally briemcnally changed the title Brie/fix publish Fix buildkite publish Dec 10, 2019
Copy link
Contributor

@gpsamson gpsamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@briemcnally briemcnally merged commit 57f1d3b into master Dec 10, 2019
@briemcnally briemcnally deleted the brie/fix-publish branch December 18, 2019 20:28
patrickotoole pushed a commit to rockerbox/analytics.js-integrations that referenced this pull request Feb 27, 2020
* Fix publish step by adding docker image

* Fix syntax

* Comment out branches filter for test

* Add auth

* Comment back in branches:master
marinhero pushed a commit to Wootric/analytics.js-integrations-1 that referenced this pull request Apr 24, 2020
* Fix publish step by adding docker image

* Fix syntax

* Comment out branches filter for test

* Add auth

* Comment back in branches:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants