Refactoring, correct package and fluent interface #149

RichardCSantana-zz · 2016-10-06T02:59:02Z

Refactoring some class.
Implement fluent interface.
Correcting some packages.

thinkingserious · 2016-10-06T23:00:05Z

Thanks for the pull request!

Before we can merge it, we need a signed CLA: https://github.com/sendgrid/sendgrid-java/blob/master/CONTRIBUTING.md#cla. Please get that over to us at [email protected] when you can.

With Best Regards,

Elmer

RichardCSantana-zz · 2016-10-07T14:38:28Z

@thinkingserious I signed it and sent the email.

thinkingserious · 2016-10-11T23:11:25Z

@richardcsantana,

Your issue has come up for pull request review. Can you please resolve the conflicts? Thanks!

RichardCSantana-zz · 2016-10-12T18:00:00Z

@thinkingserious Done

thinkingserious · 2016-10-12T18:24:10Z

Awesome, thank you!

A couple of requests:

Can you please update the README examples to reflect the changes: https://github.com/sendgrid/sendgrid-java/blob/master/README.md
Can you please list any breaking changes (for example, https://github.com/sendgrid/sendgrid-java/pull/149/files#diff-b17f74d9628458cd62154f4635856988R1)

RichardCSantana-zz · 2016-10-20T01:58:35Z

Breaking change, only the imports that I correct, I think it could be on the changelog, so I'll put it here if you don't mind to put it on changelog:

Change import com.sendgrid.Mail to import com.sendgrid.helpers.mail.Mail
change import com.sendgrid.ASM to import com.sendgrid.helpers.mail.objects.ASM                         
change import com.sendgrid.ClickTrackingSetting to import com.sendgrid.helpers.mail.objects.ClickTrackingSetting
change import com.sendgrid.FooterSetting to import com.sendgrid.helpers.mail.objects.FooterSetting
change import com.sendgrid.OpenTrackingSetting to import com.sendgrid.helpers.mail.objects.OpenTrackingSetting
change import com.sendgrid.SpamCheckSetting to import com.sendgrid.helpers.mail.objects.SpamCheckSetting
change import com.sendgrid.Attachments to import com.sendgrid.helpers.mail.objects.Attachments
change import com.sendgrid.Content to import com.sendgrid.helpers.mail.objects.Content
change import com.sendgrid.GoogleAnalyticsSetting to import com.sendgrid.helpers.mail.objects.GoogleAnalyticsSetting
change import com.sendgrid.Personalization to import com.sendgrid.helpers.mail.objects.Personalization
change import com.sendgrid.SubscriptionTrackingSetting to import com.sendgrid.helpers.mail.objects.SubscriptionTrackingSetting
change import com.sendgrid.BccSettings to import com.sendgrid.helpers.mail.objects.BccSettings
change import com.sendgrid.Email to import com.sendgrid.helpers.mail.objects.Email
change import com.sendgrid.MailSettings to import com.sendgrid.helpers.mail.objects.MailSettings
change import com.sendgrid.Setting to import com.sendgrid.helpers.mail.objects.Setting
change import com.sendgrid.TrackingSettings to import com.sendgrid.helpers.mail.objects.TrackingSettings

thinkingserious · 2016-10-20T20:43:59Z

Awesome @richardcsantana!

thinkingserious · 2017-04-11T00:03:12Z

Hello @richardcsantana,

Could you please resolve the conflicts? Thanks!

…ing content as InputStream.

…ports InputStream content

SendGridDX · 2017-04-12T16:47:01Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ dmitraver
✅ thinkingserious
✅ RichardCSantana
✅ rafalwrzeszcz
✅ SendGridDX
❌ richardcssantana
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

thinkingserious · 2017-04-12T17:09:12Z

@dmitraver,

Do you mind signing our new CLA? It only requires a short form and a click of a button now :)

dmitraver · 2017-04-12T18:24:28Z

Done!

…

On 12 April 2017 at 19:09, Elmer Thomas ***@***.***> wrote: @dmitraver <https://github.com/dmitraver>, Do you mind signing our new CLA <https://cla.sendgrid.com/sendgrid/sendgrid-java?pullRequest=149>? It only requires a short form and a click of a button now :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#149 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABtwDNPT7fzcVSbAGPwmD4H4iGO1BqV6ks5rvQU7gaJpZM4KPf10> .

-- Best wishes, Dmitry Avershin.

thinkingserious · 2017-04-17T20:20:40Z

@richardcsantana,

Could you please resolve the above conflicts? Please don't worry about any versioning, we will take care of that.

Thanks!

With Best Regards,

Elmer

…ing content as InputStream.

RichardCSantana-zz · 2017-04-17T21:01:52Z

Done!

thinkingserious · 2017-04-18T18:39:28Z

@richardcsantana,

In the file test/java/com/sendgrid/helpers/AttachmentBuilderTest.java, please replace:

import com.sendgrid.Attachments;

with

import com.sendgrid.helpers.mail.objects.Attachments;

thinkingserious

Generally I see a lot of formatting changes. Could you please review: https://github.com/sendgrid/sendgrid-java/blob/master/CONTRIBUTING.md#style_guidelines_and_naming_conventions

Thanks!

thinkingserious · 2017-04-18T18:40:14Z

README.md

@@ -126,6 +129,40 @@ public class Example {
 }
 ```

+or using fluence interface


thinkingserious · 2017-04-18T18:40:51Z

README.md

+                .setFrom(new Email("[email protected]"))
+                .setSubject("Hello World from the SendGrid Java Library!")
+                .addPersonalization(new Personalization()
+                        .addTo(new Email("[email protected]")))


The indentation is off here

thinkingserious · 2017-06-07T18:34:27Z

HI @richardcsantana,

Just checking in. Is there anything I can do to help?

thinkingserious · 2017-10-01T04:58:27Z

Implementation will be tracked in this issue.

RichardCSantana-zz mentioned this pull request Oct 6, 2016

Implement better "java state of the art" API #126

Closed

thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: cla needed labels Oct 6, 2016

thinkingserious added status: cla signed and removed status: cla needed labels Oct 10, 2016

RichardCSantana-zz force-pushed the master branch from d3e8151 to 5028af8 Compare October 12, 2016 17:59

Refactoring, correct package and fluent interface

c68b6e7

RichardCSantana-zz force-pushed the master branch from 5028af8 to 33878ce Compare October 20, 2016 01:51

Improve readme

5b88db2

RichardCSantana-zz force-pushed the master branch from 33878ce to 5b88db2 Compare October 20, 2016 01:55

dmitraver and others added 4 commits April 12, 2017 13:46

Fix sendgrid#134. Adds an attachment builder class that supports pass…

99b945a

…ing content as InputStream.

Version Bump v3.2.0: sendgrid#160 Adds an attachment builder that sup…

7b86f34

…ports InputStream content

Update CLA process

290ef82

Refactoring, correct package and fluent interface

4459c9b

dmitraver and others added 4 commits April 17, 2017 17:52

Fix sendgrid#134. Adds an attachment builder class that supports pass…

24a1074

…ing content as InputStream.

Simplified makeCall() method.

1e98e9a

Version Bump v3.2.1: sendgrid#175 Simplified method.

d63abb5

Refactoring, correct package and fluent interface

a80fac9

dmitraver and others added 2 commits April 17, 2017 17:55

Fix sendgrid#134. Adds an attachment builder class that supports pass…

21757f1

…ing content as InputStream.

Merge branch 'master' into master

dff5c06

thinkingserious requested changes Apr 18, 2017

View reviewed changes

thinkingserious added the status: work in progress Twilio or the community is in the process of implementing label Apr 29, 2017

thinkingserious closed this Oct 1, 2017

Refactoring, correct package and fluent interface #149

Refactoring, correct package and fluent interface #149

Uh oh!

Conversation

RichardCSantana-zz commented Oct 6, 2016

Uh oh!

thinkingserious commented Oct 6, 2016

Uh oh!

RichardCSantana-zz commented Oct 7, 2016

Uh oh!

thinkingserious commented Oct 11, 2016

Uh oh!

RichardCSantana-zz commented Oct 12, 2016

Uh oh!

thinkingserious commented Oct 12, 2016

Uh oh!

RichardCSantana-zz commented Oct 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thinkingserious commented Oct 20, 2016

Uh oh!

thinkingserious commented Apr 11, 2017

Uh oh!

SendGridDX commented Apr 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thinkingserious commented Apr 12, 2017

Uh oh!

dmitraver commented Apr 12, 2017 via email

Uh oh!

thinkingserious commented Apr 17, 2017

Uh oh!

RichardCSantana-zz commented Apr 17, 2017

Uh oh!

thinkingserious commented Apr 18, 2017

Uh oh!

thinkingserious left a comment

Choose a reason for hiding this comment

Uh oh!

thinkingserious Apr 18, 2017

Choose a reason for hiding this comment

Uh oh!

thinkingserious Apr 18, 2017

Choose a reason for hiding this comment

Uh oh!

thinkingserious commented Jun 7, 2017

Uh oh!

thinkingserious commented Oct 1, 2017

Uh oh!

Uh oh!

RichardCSantana-zz commented Oct 20, 2016 •

edited

Loading

SendGridDX commented Apr 12, 2017 •

edited

Loading