You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
match_token was bumped to 0.1.1 in #621 and contains a breaking change coming from #593, it should have been a bump to 0.2.0 as 0.1.0 to 0.1.1 isn't considered a breaking change.
The consequence of that, is anyone that is using html5ever 0.31 will now attempt to build it against match_token 0.1.1 resulting in a compilation error. Publishing html5ever 0.32 won't solve the issue as Cargo won't use the version 0.32 when the requirements is ^0.31. Therefore, the only solution is to yank the version 0.1.1 of match_token and re-publish it with the version 0.2.0.
Since html5ever is widely used, this issue will impact a large number of users, such as our current inability to install mdbook, which depends on ammonia, which in turn depends on html5ever 0.31.
Cargo's CI is failing because of this is causing linkchecker to fail to build which uses html5ever@0.29.0. The way linkchecker.sh works is it downloads only the Cargo.toml and main.rs so we don't have access to the lockfile.
@servo/cargo-publish Can someone yank version 0.1.1 of the match_token crates as a matter of urgency? It seems we're breaking the CI of at least Cargo and MDBook.
@servo/cargo-publish Can someone yank version 0.1.1 of the match_token crates as a matter of urgency? It seems we're breaking the CI of at least Cargo and MDBook.
Done.
nicoburns, Quentin01, kornelski, ford-prefect, Skardyy and 1 morejoshtriplett
Activity
epage commentedon Jun 20, 2025
Cargo's CI is failing because of this is causing linkchecker to fail to build which uses
html5ever@0.29.0
. The waylinkchecker.sh
works is it downloads only theCargo.toml
andmain.rs
so we don't have access to the lockfile.nicoburns commentedon Jun 20, 2025
@servo/cargo-publish Can someone yank version
0.1.1
of thematch_token
crates as a matter of urgency? It seems we're breaking the CI of at least Cargo and MDBook.fix(linkcheck): Build using the lockfile
fix(linkcheck): Build using the lockfile
sagudev commentedon Jun 20, 2025
Done.
sagudev commentedon Jun 20, 2025
We will still need to republish
match_token
as 0.2.0 and publish patch releases for other crates with new version ofmatch_token
.atouchet commentedon Jun 20, 2025
The html5ever 0.32 release depends on match_token 0.1.1. Should that be yanked too?
nicoburns commentedon Jun 20, 2025
It makes less difference for html5ever 0.32 as it is not possible to install it either way. Probably:
0.32.1
release that depends on match_token0.2.0
should be made0.32.0
should be yankedBut this is less immediately urgent and the ordering is less important as it won't break anyone's build, they just won't be able to upgrade.
nicoburns commentedon Jun 20, 2025
Somebody should probably check my work, but I have attempted to go through and fixup all of the crates in the repository in #625
Rollup merge of rust-lang#142785 - epage:link, r=ehuss
Unrolled build for #142785
1 remaining item