Skip to content

Breaking change published with non-breaking version bump for match_token which breaks anyone using html5ever 0.31 #623

@Quentin01

Description

@Quentin01

match_token was bumped to 0.1.1 in #621 and contains a breaking change coming from #593, it should have been a bump to 0.2.0 as 0.1.0 to 0.1.1 isn't considered a breaking change.

The consequence of that, is anyone that is using html5ever 0.31 will now attempt to build it against match_token 0.1.1 resulting in a compilation error. Publishing html5ever 0.32 won't solve the issue as Cargo won't use the version 0.32 when the requirements is ^0.31. Therefore, the only solution is to yank the version 0.1.1 of match_token and re-publish it with the version 0.2.0.

Since html5ever is widely used, this issue will impact a large number of users, such as our current inability to install mdbook, which depends on ammonia, which in turn depends on html5ever 0.31.

Thanks

Activity

epage

epage commented on Jun 20, 2025

@epage

Cargo's CI is failing because of this is causing linkchecker to fail to build which uses html5ever@0.29.0. The way linkchecker.sh works is it downloads only the Cargo.toml and main.rs so we don't have access to the lockfile.

nicoburns

nicoburns commented on Jun 20, 2025

@nicoburns
Contributor

@servo/cargo-publish Can someone yank version 0.1.1 of the match_token crates as a matter of urgency? It seems we're breaking the CI of at least Cargo and MDBook.

sagudev

sagudev commented on Jun 20, 2025

@sagudev
Member

@servo/cargo-publish Can someone yank version 0.1.1 of the match_token crates as a matter of urgency? It seems we're breaking the CI of at least Cargo and MDBook.

Done.

sagudev

sagudev commented on Jun 20, 2025

@sagudev
Member

We will still need to republish match_token as 0.2.0 and publish patch releases for other crates with new version of match_token.

atouchet

atouchet commented on Jun 20, 2025

@atouchet
Contributor

The html5ever 0.32 release depends on match_token 0.1.1. Should that be yanked too?

nicoburns

nicoburns commented on Jun 20, 2025

@nicoburns
Contributor

It makes less difference for html5ever 0.32 as it is not possible to install it either way. Probably:

  • A 0.32.1 release that depends on match_token 0.2.0 should be made
  • 0.32.0 should be yanked

But this is less immediately urgent and the ordering is less important as it won't break anyone's build, they just won't be able to upgrade.

nicoburns

nicoburns commented on Jun 20, 2025

@nicoburns
Contributor

Somebody should probably check my work, but I have attempted to go through and fixup all of the crates in the repository in #625

added a commit that references this issue on Jun 21, 2025
06cc41b
added a commit that references this issue on Jun 21, 2025

1 remaining item

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @epage@nicoburns@Quentin01@sagudev@atouchet

      Issue actions

        Breaking change published with non-breaking version bump for match_token which breaks anyone using html5ever 0.31 · Issue #623 · servo/html5ever