Added Wrapper for NewArrayBufferWithContents #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redfire75369
force-pushed
the
array-buffer/unique-ptr
branch
2 times, most recently
from
fc73188 to
5595fe8
Compare
jdm
approved these changes
Jul 29, 2024
|
This will need rebase after #483 lands, so let's wait for it to land. |
Added Array Buffer Functions using `js::UniquePtr` to Bindgen Blacklist Signed-off-by: Redfire <[email protected]>
sagudev
force-pushed
the
array-buffer/unique-ptr
branch
from
5595fe8 to
fe0c843
Compare
Signed-off-by: Redfire <[email protected]>
redfire75369
force-pushed
the
array-buffer/unique-ptr
branch
from
fe0c843 to
d687d67
Compare
|
Rebased on latest, with version bump accordingly. |
jschwe
pushed a commit
to jschwe/mozjs
that referenced
this pull request
Aug 2, 2024
* Added Wrapper for NewArrayBufferWithContents Added Array Buffer Functions using `js::UniquePtr` to Bindgen Blacklist Signed-off-by: Redfire <[email protected]> * Bumped mozjs-sys Version Signed-off-by: Redfire <[email protected]> --------- Signed-off-by: Redfire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the two wrapped array buffer functions from the bindings also shortens imports (
mozjs::jsapi::<function>as compared tomozjs::jsapi::glue::<function>).