Added Wrapped NewArrayBufferWithContents to Header #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reformatted C++ Files with clang-format Signed-off-by: Redfire <[email protected]>
|
I hate header files (so error prone). What if we just use .cpp files and feed those to bindgen? (we already do this in mozangle). |
|
Actually jsglue.cpp is already without header, so we should make jsapi.cpp too. |
jdm
approved these changes
Jul 29, 2024
jschwe
pushed a commit
to jschwe/mozjs
that referenced
this pull request
Aug 2, 2024
Reformatted C++ Files with clang-format Signed-off-by: Redfire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to add it to the header in #482, so here's a fix for that.