Store clip node templates in local space. #3383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes clip item keys independent of the local space origin of the node. This ensures that even when Gecko sends a new display list with clip nodes that have different scroll offsets the interning logic results in the same uid for the clip node, avoiding unnecessary invalidations of cached picture tiles.
|
This is a If you have ideas on tidier ways to implement this, let me know. r? @kvark |
|
Pending try (but looks good so far): |
|
Try run looks good. |
|
Closing in favor of #3384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes clip item keys independent of the local space
origin of the node. This ensures that even when Gecko sends a
new display list with clip nodes that have different scroll offsets
the interning logic results in the same uid for the clip node,
avoiding unnecessary invalidations of cached picture tiles.
This change is