Switch segments to be defined relative to the local primitive position. #3384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes clip item keys independent of the local space origin of the node. This ensures that even when Gecko sends a new display list with clip nodes that have different scroll offsets the interning logic results in the same uid for the clip node, avoiding unnecessary invalidations of cached picture tiles.
|
Try run looks good. |
kvark
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
Reviewed 18 of 18 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gw3583)
webrender/res/cs_clip_rectangle.glsl, line 68 at r1 (raw file):
RectWithSize local_rect = clip.rect.rect; local_rect.p0 = cmi.local_pos;
I read it as local_rect.p0 is guaranteed to be zero here
webrender/src/box_shadow.rs, line 202 at r1 (raw file):
shadow_rect, shadow_radius, dest_rect.translate(&LayoutVector2D::new(-prim_info.rect.origin.x, -prim_info.rect.origin.y)),
nit: -prim_info.rect.origin.to_vector()?
|
@bors-servo r+ |
|
📌 Commit 46700de has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 5, 2018
Switch segments to be defined relative to the local primitive position. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3384) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
This was referenced Dec 5, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 5, 2018
…82290855e227 (WR PR #3384). r=kats servo/webrender#3384 Differential Revision: https://phabricator.services.mozilla.com/D13799 --HG-- extra : moz-landing-system : lando
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Dec 5, 2018
…82290855e227 (WR PR #3384). r=kats servo/webrender#3384 Differential Revision: https://phabricator.services.mozilla.com/D13799
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…82290855e227 (WR PR #3384). r=kats servo/webrender#3384 Differential Revision: https://phabricator.services.mozilla.com/D13799 UltraBlame original commit: c67f67bb48d5594fba32666623cc7563aabcb08f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…82290855e227 (WR PR #3384). r=kats servo/webrender#3384 Differential Revision: https://phabricator.services.mozilla.com/D13799 UltraBlame original commit: c67f67bb48d5594fba32666623cc7563aabcb08f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…82290855e227 (WR PR #3384). r=kats servo/webrender#3384 Differential Revision: https://phabricator.services.mozilla.com/D13799 UltraBlame original commit: c67f67bb48d5594fba32666623cc7563aabcb08f
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…82290855e227 (WR PR #3384). r=kats servo/webrender#3384 Differential Revision: https://phabricator.services.mozilla.com/D13799
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is