Skip to content

Make window step default to window size #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 19, 2020
Merged

Make window step default to window size #389

merged 3 commits into from
Nov 19, 2020

Conversation

tomwhite
Copy link
Collaborator

A simplification that addresses this comment: https://github.com/pystatgen/sgkit/pull/303#discussion_r508392377

jeromekelleher
jeromekelleher approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and it does simplify code quite nicely.

We should have an explicit test that the default does this, though?

@tomwhite tomwhite force-pushed the window-step-default branch from e6dcbcb to 07fb874 Compare November 19, 2020 09:28
@jeromekelleher jeromekelleher added the auto-merge Auto merge label for mergify test flight label Nov 19, 2020
@mergify mergify bot merged commit 1880cfd into sgkit-dev:master Nov 19, 2020
@tomwhite tomwhite deleted the window-step-default branch November 19, 2020 14:41
@tomwhite tomwhite mentioned this pull request Nov 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromekelleher jeromekelleher jeromekelleher approved these changes

Assignees
No one assigned
Labels
auto-merge Auto merge label for mergify test flight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomwhite @jeromekelleher