Updated libraries and linters #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @dylangrafmyre @jbhatab @alexfedoseev |
robwise
added a commit
to shakacode/react_on_rails
that referenced
this pull request
Nov 21, 2015
This change is in paralell with the change made for the webpack tutorial. See shakacode/react-webpack-rails-tutorial#159
robwise
added a commit
to shakacode/react_on_rails
that referenced
this pull request
Nov 21, 2015
This change is in parallel with the change made for the webpack tutorial. See shakacode/react-webpack-rails-tutorial#159
|
@robwise Please confirm that newly generated code passes these linters. |
| __SERVER_ERRORS__: true | ||
| google: true | ||
| amenitiesList: true | ||
| File: true |
There was a problem hiding this comment.
Let's remove google, amenitiesList & File from here, it's project specific.
There was a problem hiding this comment.
Done. I should have caught that.
Linters conform to ShakaCode internal project standards.
justin808
force-pushed
the
update-libs-and-linters
branch
from
8d42b14 to
ec32459
Compare
justin808
added a commit
that referenced
this pull request
Nov 22, 2015
Updated libraries and linters
robwise
added a commit
to shakacode/react_on_rails
that referenced
this pull request
Nov 23, 2015
This change is in parallel with the change made for the webpack tutorial. See shakacode/react-webpack-rails-tutorial#159
robwise
added a commit
to shakacode/react_on_rails
that referenced
this pull request
Nov 23, 2015
This change is in parallel with the change made for the webpack tutorial. See shakacode/react-webpack-rails-tutorial#159 - Fix generator linters templating logic for scss task - Remove unnecessary lodash import in generated loggerMiddleware - Exclude dummy apps from linting - Remove unnecessary 'refs' attribute in generated component - Add dummy apps to eslintignore
superdev9082
added a commit
to superdev9082/react_on_rails
that referenced
this pull request
Feb 16, 2023
This change is in parallel with the change made for the webpack tutorial. See shakacode/react-webpack-rails-tutorial#159 - Fix generator linters templating logic for scss task - Remove unnecessary lodash import in generated loggerMiddleware - Exclude dummy apps from linting - Remove unnecessary 'refs' attribute in generated component - Add dummy apps to eslintignore
Web-Go-To
added a commit
to Web-Go-To/react-with-rails
that referenced
this pull request
Mar 19, 2023
This change is in parallel with the change made for the webpack tutorial. See shakacode/react-webpack-rails-tutorial#159 - Fix generator linters templating logic for scss task - Remove unnecessary lodash import in generated loggerMiddleware - Exclude dummy apps from linting - Remove unnecessary 'refs' attribute in generated component - Add dummy apps to eslintignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linters conform to ShakaCode internal project standards.