Update linters to conform to ShakaCode standards #112
Conversation
robwise
force-pushed
the
update-linters
branch
from
2bddb80 to
d6c689c
Compare
| globals: | ||
| __DEBUG_SERVER_ERRORS__: true | ||
| __SERVER_ERRORS__: true | ||
| google: true |
robwise
force-pushed
the
update-linters
branch
from
3934225 to
931692b
Compare
|
@dylangrafmyre I'm pretty sure we're failing the linters in CI because of needing to update our eslint dependencies. I pass with the latest version of eslint (v1.10.1) locally, but the docker container is shrinkwrapped to v1.6.0. How do I go about updating this? |
|
@robwise just need to update the package.json and npm shrinkwrap followed by a push to origin(shakacode/docker-lint). This will trigger a new build of the container image on Docker Hub. And when CI runs it will pull down the latest build. I can help with this if needed? |
|
Thanks @dylangrafmyre for helping me on this! We had to update the linter dependencies in the docker image. This should be good to go pending a final review. |
|
Looks good. Let's merge. |
|
@robwise Did you confirm that the generated code passes these linter changes? |
|
@justin808 affirmative, good to go |
This change is in parallel with the change made for the webpack tutorial. See shakacode/react-webpack-rails-tutorial#159 - Fix generator linters templating logic for scss task - Remove unnecessary lodash import in generated loggerMiddleware - Exclude dummy apps from linting - Remove unnecessary 'refs' attribute in generated component - Add dummy apps to eslintignore
robwise
force-pushed
the
update-linters
branch
from
9de48e4 to
3573d80
Compare
Update linters to conform to ShakaCode standards
This change is in parallel with the change made for the webpack
tutorial.
See shakacode/react-webpack-rails-tutorial#159