Skip to content

Webpack v4 Update #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Webpack v4 Update #460

wants to merge 4 commits into from

Conversation

pulkitkkr
Copy link

@pulkitkkr pulkitkkr commented Mar 16, 2019

  • Removed CommonChunkPlugin for SplitChunksPlugin (v3--> v4)
  • Misc Plugins Updates
  • added Mode (v3 --> v4)

This change is Reviewable

@pulkitkkr pulkitkkr force-pushed the pulkit-webpack-update branch from c6fb3ba to c86e8a9 Compare March 16, 2019 12:08
@pulkitkkr pulkitkkr force-pushed the pulkit-webpack-update branch from a76e3b3 to bdd2574 Compare March 17, 2019 17:50
test: /\.(woff2?|jpe?g|png|gif|svg|ico)$/,
test: /\.(woff2|woff|jpe?g|png|gif|ico)?$/,
use: {
loader: 'resource-url-loader',
Copy link
Collaborator

@Judahmeek Judahmeek Jul 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loader: 'url-loader',

@@ -32,7 +35,7 @@ module.exports = merge(config, {
'bootstrap-loader/extractStyles'
],
},

mode: process.env.NODE_ENV,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this and add

mode: process.env.NODE_ENV === 'development' ? 'development' : 'production',

to client/webpack.client.base.config.js & client/webpack.server.rails.build.config.js

@Judahmeek
Copy link
Collaborator

Judahmeek commented Jul 7, 2019

There's two other errors that I have not been able to resolve:

1.) The relative path in bootstrap-pre-customizations won't resolve correctly and adding resolve-url-loader to the test: /\.scss$/ for the rails.hot or rails.build doesn't seem to accomplish anything.

2.) bootstrap-loader seems to be trying load its path twice, leading to the following error:
Screen Shot 2019-07-06 at 7 28 07 PM
(the Module not found: Error: Can't resolve '../bootstrap-sass/assets/stylesheets/bootstrap-sass/assets/fonts-... right under the red text seems most relevant)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants