Trait codegen: less restrictive namespace check #2671
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"smithy." or an exact match of "smithy"
kubukoz
commented
Jun 19, 2025
| @@ -55,8 +55,8 @@ public final class TraitCodegenSettings { | |||
| ) { | |||
| this.packageName = Objects.requireNonNull(packageName); | |||
| this.smithyNamespace = Objects.requireNonNull(smithyNamespace); | |||
| if (smithyNamespace.startsWith(SMITHY_API_NAMESPACE)) { | |||
| throw new IllegalArgumentException("The `smithy` namespace is reserved."); | |||
| if (smithyNamespace.equals(SMITHY_API_NAMESPACE) || smithyNamespace.startsWith(SMITHY_API_NAMESPACE + ".")) { | |||
There was a problem hiding this comment.
actually, SMITHY_API_NAMESPACE is set to smithy. Shouldn't it just be smithy.api?
There was a problem hiding this comment.
Let's keep it this way. The variable needs to be adjusted but we want this value.
|
Hi team, can we have some eyes on this? |
|
Yes, apologies for the delay. Let me circle back with the team about it. |
sugmanue
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow namespaces like
smithy4s, but notsmithyorsmithy.apior other sub-smithynamespaces.Background
Testing
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.