Skip to content

Trait codegen: less restrictive namespace check #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025
Merged

Trait codegen: less restrictive namespace check #2671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...trait-codegen/src/main/java/software/amazon/smithy/traitcodegen/TraitCodegenSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ public final class TraitCodegenSettings {
) {
this.packageName = Objects.requireNonNull(packageName);
this.smithyNamespace = Objects.requireNonNull(smithyNamespace);
if (smithyNamespace.startsWith(SMITHY_API_NAMESPACE)) {
throw new IllegalArgumentException("The `smithy` namespace is reserved.");
if (smithyNamespace.equals(SMITHY_API_NAMESPACE) || smithyNamespace.startsWith(SMITHY_API_NAMESPACE + ".")) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, SMITHY_API_NAMESPACE is set to smithy. Shouldn't it just be smithy.api?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it this way. The variable needs to be adjusted but we want this value.

throw new IllegalArgumentException("The `smithy` namespace and its sub-namespaces are reserved.");
}
this.headerLines = Objects.requireNonNull(headerLines);
this.excludeTags = Objects.requireNonNull(excludeTags);
Expand Down