-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
CI: fix python-3.13 tests #12148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: fix python-3.13 tests #12148
Conversation
The apt package appears to have disappeared in the last hours: "Unable to locate package python3.13-dev"
@@ -36,7 +36,7 @@ jobs: | |||
- "3.10" | |||
- "3.11" | |||
- "3.12" | |||
- "3.13-dev" | |||
- "3.13.0-alpha.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this package version being retrieved from?
I don't see it listed in the deadsnakes
nightly PPA at the moment:
https://launchpad.net/~deadsnakes/+archive/ubuntu/ppa/+packages
(the latest versions I find available there are python3.13 - 3.13.0~a4-1+jammy1
and python3.13 - 3.13.0~a4-1+focal1
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't use deadsnakes unless its -dev
, this is coming from the "core" apt registry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to understand a bit more about the cause before making changes to our CI configuration, and initially would prefer temporarily disabling python3.13-dev
instead of fixing a specific image name.
Note also that fuzzing is temporarily disabled in Python's continuous integration at the moment (ref python/cpython#116886)
Here's where the deadsnakes
action code begins to figure out what image to retrieve:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would prefer temporarily disabling python3.13-dev instead of fixing a specific image name
I feel temporarily changing the name is much preferable than entirely disabling it;
at the end if the day 3.13.0-alpha.5
and python3.13-dev
will be exactly the same for the next month (see https://peps.python.org/pep-0719/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danieleades @picnixz thoughts? maybe this issue will just fix itself soon, I dunno, how long do we want to stall on merging PRs 🤷 (or merge with failing tests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I won't be available today anymore. In the future, I don't care about the PRs meant to patch the CI/CD since it's only for us and has no downstream effect. So I leave it to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More generally I want don't want to merge to master if tests are failing (ie, make it work even if we need to revert it later).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem seems to relate to HTTP 503 responses from the Ubuntu PPA serving the nightly images:
W: Failed to fetch https://ppa.launchpadcontent.net/deadsnakes/nightly/ubuntu/dists/jammy/InRelease 503 Service Unavailable [IP: .... 443]
W: Failed to fetch https://ppa.launchpadcontent.net/ubuntu-toolchain-r/test/ubuntu/dists/jammy/InRelease 503 Service Unavailable [IP: .... 443]
My guess is that it's related to this infrastructure maintenance: https://ubuntu.social/@launchpadstatus/112128869030316721
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ubuntu PPA service should now be restored; I'll update one of my pull request branches in a few moments to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ubuntu PPA service should now be restored; I'll update one of my pull request branches in a few moments to check.
🎉 Yep - that's functional again. Welcome back, 3.13-dev
! https://github.com/sphinx-doc/sphinx/actions/runs/8364765692/job/22900905325?pr=12144
The
python3.13-dev
apt package has disappeared in the last few hours: "Unable to locate package python3.13-dev" (https://github.com/sphinx-doc/sphinx/actions/runs/8361442940/job/22889531537?pr=12146)this change appears to work? (we can always change back to
dev
at a later date, if it starts working again)