Skip to content

CI: fix python-3.13 tests #12148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

CI: fix python-3.13 tests #12148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df4949a
CI: fix python-3.13 tests
chrisjsewell Mar 20, 2024
e1f2910
Update main.yml
chrisjsewell Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- "3.10"
- "3.11"
- "3.12"
- "3.13-dev"
- "3.13.0-alpha.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this package version being retrieved from?

I don't see it listed in the deadsnakes nightly PPA at the moment:

https://launchpad.net/~deadsnakes/+archive/ubuntu/ppa/+packages

(the latest versions I find available there are python3.13 - 3.13.0~a4-1+jammy1 and python3.13 - 3.13.0~a4-1+focal1)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't use deadsnakes unless its -dev, this is coming from the "core" apt registry

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to understand a bit more about the cause before making changes to our CI configuration, and initially would prefer temporarily disabling python3.13-dev instead of fixing a specific image name.

Note also that fuzzing is temporarily disabled in Python's continuous integration at the moment (ref python/cpython#116886)

Here's where the deadsnakes action code begins to figure out what image to retrieve:

https://github.com/deadsnakes/action/blob/8e851ac3dbb4b8d562383da899c9876e23dcb6b2/bin/install-python#L44-L46

Copy link
Member Author

@chrisjsewell chrisjsewell Mar 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would prefer temporarily disabling python3.13-dev instead of fixing a specific image name

I feel temporarily changing the name is much preferable than entirely disabling it;
at the end if the day 3.13.0-alpha.5 and python3.13-dev will be exactly the same for the next month (see https://peps.python.org/pep-0719/)

Copy link
Member Author

@chrisjsewell chrisjsewell Mar 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danieleades @picnixz thoughts? maybe this issue will just fix itself soon, I dunno, how long do we want to stall on merging PRs 🤷 (or merge with failing tests)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I won't be available today anymore. In the future, I don't care about the PRs meant to patch the CI/CD since it's only for us and has no downstream effect. So I leave it to you

Copy link
Member

@picnixz picnixz Mar 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More generally I want don't want to merge to master if tests are failing (ie, make it work even if we need to revert it later).

Copy link
Contributor

@jayaddison jayaddison Mar 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem seems to relate to HTTP 503 responses from the Ubuntu PPA serving the nightly images:

https://github.com/sphinx-doc/sphinx/actions/runs/8361626870/job/22890154532?pr=12149#step:4:54

W: Failed to fetch https://ppa.launchpadcontent.net/deadsnakes/nightly/ubuntu/dists/jammy/InRelease 503 Service Unavailable [IP: .... 443]
W: Failed to fetch https://ppa.launchpadcontent.net/ubuntu-toolchain-r/test/ubuntu/dists/jammy/InRelease 503 Service Unavailable [IP: .... 443]

My guess is that it's related to this infrastructure maintenance: https://ubuntu.social/@launchpadstatus/112128869030316721

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu PPA service should now be restored; I'll update one of my pull request branches in a few moments to check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu PPA service should now be restored; I'll update one of my pull request branches in a few moments to check.

🎉 Yep - that's functional again. Welcome back, 3.13-dev! https://github.com/sphinx-doc/sphinx/actions/runs/8364765692/job/22900905325?pr=12144

docutils:
- "0.18"
- "0.20"
Expand Down