Skip to content

ref(Dockerfiles): go/tinygo bumps per latest 0.9.0 go templates/SDK #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

vdice
Copy link
Contributor

@vdice vdice commented Feb 15, 2023

Passing e2e is blocked on #1153 (comment). I don't think these bumps are urgent, so this is fine to wait.

@vdice vdice mentioned this pull request Feb 15, 2023
@vdice
Copy link
Contributor Author

vdice commented Feb 15, 2023

I should note this updates the tinygo binary version and cli usage but doesn't attempt any SDK updates.

Although the http-go template and http-tinygo example each build and run fine with these changes and make test-sdk-go passes locally, there may be SDK updates necessary. (Alas, the integration tests for a running app currently only use the http-go app. We're seeing behavior where other (tiny)go-based apps aren't functioning as expected, so we may want to add a few more to the mix.)

I'll move to Draft while we learn a bit more from the linked issue; also @dicej is working on feature-related updates to the go SDK as well, so there will be at least one associated PR.

Now that #1165 is in, this just bumps versions in a few more spots.

@vdice vdice marked this pull request as draft February 15, 2023 23:27
@vdice vdice force-pushed the ref/tinygo-0.27.0-updates branch 3 times, most recently from 4813245 to bcc206a Compare February 16, 2023 16:59
@vdice
Copy link
Contributor Author

vdice commented Feb 16, 2023

The e2e test failure is due to #1161; the http-go template under test is from the most recent spin template tag and thus doesn't have the changes added in this PR for tinygo 0.27.0 compatibility.

@vdice vdice force-pushed the ref/tinygo-0.27.0-updates branch from bcc206a to 42ff52c Compare February 16, 2023 23:09
@vdice vdice force-pushed the ref/tinygo-0.27.0-updates branch from 42ff52c to 7330584 Compare February 17, 2023 17:57
@vdice vdice marked this pull request as ready for review February 17, 2023 18:56
@vdice
Copy link
Contributor Author

vdice commented Feb 17, 2023

e2e is happy, so moving to ready for review. Although behavior described in #1161 remains, the tests now fetch the latest v0.9.0 templates which are compatible with the bumps in this PR.

@vdice vdice changed the title ref(sdk/go): updates per tinygo 0.27.0 ref(Dockerfiles): updates go/tinygo bumps per latest 0.9.0 go templates/SDK Feb 17, 2023
@vdice vdice changed the title ref(Dockerfiles): updates go/tinygo bumps per latest 0.9.0 go templates/SDK ref(Dockerfiles): go/tinygo bumps per latest 0.9.0 go templates/SDK Feb 17, 2023
@vdice vdice requested a review from rajatjindal February 17, 2023 18:58
@vdice vdice merged commit 6e7fd6b into spinframework:main Feb 22, 2023
@vdice vdice deleted the ref/tinygo-0.27.0-updates branch February 22, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants