-
Notifications
You must be signed in to change notification settings - Fork 270
grand Go SDK update #1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grand Go SDK update #1165
Conversation
@@ -62,6 +66,80 @@ func init() { | |||
w.Write([]byte(strconv.FormatInt(payload, 10))) | |||
w.Write([]byte("\n")) | |||
} | |||
|
|||
if _, err := redis.Sadd(addr, "myset", []string{"foo", "bar"}); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadd
😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that's the second time you've made that joke.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WELL ITS STILL JUST AS FUNNY
Somehow I forget to sign commits 50% of the time. I blame |
- Add `outbound-redis` set operations and `execute` function - Add `key-value` support - Remove `*_free` calls since they were buggy and unnecessary given that we tell `tinygo` to leak anyway - Remove `-wasm-abi=generic` option since it's been removed as of `tinygo` 0.27 Signed-off-by: Joel Dice <[email protected]>
This might appeal to you (all my Fermyon repos are under
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @dicej
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to fix running the tinygo-based Spin apps/templates 🎉 -- at least it did so for me (go 1.19.6, tinygo 0.27.0)
Per the updated tinygo usage, you may need to bump go and tinygo versions a la #1153 for CI (test-sdk-go) to pass, though note #1153 (comment). Assuming you do, I can close 1153 as the rest of the changes are already here.
- Update Go and `tinygo` versions - Use `interface{}` instead of `any` for broader compatibility - Make `tinygo-outbound-redis` example sort the `SMEMBERS` result before comparing with the expected value Signed-off-by: Joel Dice <[email protected]>
Signed-off-by: Joel Dice <[email protected]>
outbound-redis
set operations andexecute
functionkey-value
support*_free
calls since they were buggy and unnecessary given that we telltinygo
to leak anyway-wasm-abi=generic
option since it's been removed as oftinygo
0.27