Metadata on Events - New Errors listener - To Development #722
+883
−508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FME-8393] - Events - Metadata
…0, but the JSON has the wrong structure
Co-authored-by: gthea <[email protected]>
[FME-8356] - Events - Errors Metadata
Workers Cleanup
MartinCardozo-SDK
changed the title
MartinCardozo-SDK
changed the title
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS SDK
What did you accomplish?
Events now support metadata by default (both internal and external).
For now, we are using this to propagate error messages to the customer, that they can get by attaching themselves to a new SDK event listener ( on(event: sdkError )
Spec (to be expanded):
https://docs.google.com/document/d/1iNwbDT42KlfuoZqryugz9J1EMLrlVx70k8fxTo6H_pY/edit?tab=t.0
How do we test the changes introduced in this PR?
Extra Notes
SonarQube is not passing the quality gate because there were some old untested classes that have been refactored. But the logic is the same, and all tests are passing.