update-scheduled-release-version mistakenly reports success when failure happens

[rwinch]

The update-scheduled-release-version reports success when a step fails See https://github.com/spring-projects-experimental/spring-boot-testjars/actions/runs/7672549320/job/20913290023

When fails on Get Next Release Milestone

[jhl221123]

Hi @rwinch,

Regarding #15 and its relation to spring-projects/spring-security#16764:

The issue seems to be that when a Gradle task (like getNextReleaseMilestone or checkMilestoneIsDueToday) fails, wrapping its execution directly within echo "key=$(./gradlew ...)" >> $GITHUB_OUTPUT causes the step to (incorrectly) report success because the echo command itself succeeds.

My tests confirm that changing the script to first assign the Gradle output to a variable, and then separately echoing that variable to $GITHUB_OUTPUT, allows the step to correctly fail when the Gradle task fails.

Proposal:
In update-scheduled-release-version.yml, modify steps executing Gradle tasks from:

run: echo "result=$(./gradlew -q taskName ...)" >> $GITHUB_OUTPUT

To something like:

run: |
  result_task=$(./gradlew -q taskName ...)
  echo "result=$result_task" >> $GITHUB_OUTPUT

This ensures the step fails if ./gradlew fails, while preserving the output mechanism.

I'm available to submit a PR for this. What are your thoughts?

Thanks!