Skip to content

Fix step success reporting on Gradle failure #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhl221123
Copy link

This PR fixes an issue where GitHub Actions steps in the update-scheduled-release-version.yml workflow would incorrectly report success even if an internal Gradle task failed.

The problem was caused by wrapping the Gradle execution directly within an echo "key=$(./gradlew ...)" >> $GITHUB_OUTPUT command. The echo command itself would succeed, masking the underlying Gradle failure.

This change modifies the script to:

  1. First, assign the standard output of the Gradle task to a variable.
  2. Then, separately echo this variable's value to $GITHUB_OUTPUT using the key=value format.

This ensures that if the Gradle task fails, the step will now correctly report a failure.

Addresses #15
Related to spring-projects/spring-security#16764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant