Skip to content

Add getUniqueJobParametersBuilder() method in JobLauncherTestUtils #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Oct 6, 2019 · 1 comment
Closed

Add getUniqueJobParametersBuilder() method in JobLauncherTestUtils #767

spring-projects-issues opened this issue Oct 6, 2019 · 1 comment
Labels
in: test type: feature
Milestone
4.3.0

Comments

@spring-projects-issues
Copy link
Collaborator

jojoldu opened BATCH-2847 and commented

JobLauncherTestUtils often uses the getUniqueJobParameters method.
But it seems a bit cumbersome to use this method with other JobParameters.
In the same case, I use it like this:

new JobParametersBuilder(jobLauncherTestUtils.getUniqueJobParameters())
.addString()
.addDouble()

I want to make this convenient.

jobLauncherTestUtils.getUniqueJobParametersBuilder()
.addString()
.addDouble()

What do you think?

Affects: 4.2.0

Referenced from: pull request #734
fmbenhassine pushed a commit that referenced this issue Jul 24, 2020
@jojoldu @fmbenhassine
Add getUniqueJobParametersBuilder() method in JobLauncherTestUtils
60bbc00 
Issue #767
@fmbenhassine fmbenhassine removed the status: waiting-for-triage Issues that we did not analyse yet label Jul 24, 2020
@fmbenhassine fmbenhassine added this to the 4.3.0 milestone Jul 24, 2020
@fmbenhassine
Copy link
Contributor

Resolved with #734 .

@fmbenhassine fmbenhassine changed the title Add getUniqueJobParametersBuilder() in JobLauncherTestUtils. [BATCH-2847] Add getUniqueJobParametersBuilder() method in JobLauncherTestUtils Jul 24, 2020
@fmbenhassine fmbenhassine mentioned this issue Jul 24, 2020
Closed
@dependabot dependabot bot mentioned this issue Mar 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: test type: feature
Projects
None yet
Milestone
4.3.0
Development

No branches or pull requests
2 participants
@fmbenhassine @spring-projects-issues