Skip to content

BATCH-2847: Add getUniqueJobParametersBuilder() in JobLauncherTestUtils #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jojoldu
Copy link
Contributor

@jojoldu jojoldu commented Oct 6, 2019

JobLauncherTestUtils often uses the getUniqueJobParameters method.
But it seems a bit cumbersome to use this method with other JobParameters.
In the same case, I use it like this:

new JobParametersBuilder(jobLauncherTestUtils.getUniqueJobParameters())
.addString()
.addDouble()

I want to make this convenient.

jobLauncherTestUtils.getUniqueJobParametersBuilder()
.addString()
.addDouble()

@fmbenhassine
Copy link
Contributor

LGTM. Rebased, squashed and merged as 60bbc00.

@jojoldu Thank you for your contribution!

@jojoldu
Copy link
Contributor Author

jojoldu commented Jul 24, 2020

@benas Oh, Thanks.

I hope I can contribute next time.
Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants