Skip to content

Added connectionAutoCommit property in JdbcCursorItemReaderBuilder #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

trapaank
Copy link
Contributor

@trapaank trapaank commented May 26, 2020

Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest master branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

For more details, please check the contributor guide.
Thank you upfront!

@fmbenhassine fmbenhassine changed the title Added connectionAutoCommit property in Builder for JdbcCursorItemRead… Added connectionAutoCommit property in JdbcCursorItemReaderBuilder May 26, 2020
@fmbenhassine
Copy link
Contributor

@ankurtrapasiya Thank you for your PR. Please rebase your changes on the latest master branch and avoid changing the code formatting and import statements order. Do not hesitate to add your name to the @author javadoc tag and update the year in license headers of the files you changed.

Thank you upfront.

@trapaank
Copy link
Contributor Author

@ankurtrapasiya Thank you for your PR. Please rebase your changes on the latest master branch and avoid changing the code formatting and import statements order. Do not hesitate to add your name to the @author javadoc tag and update the year in license headers of the files you changed.

Thank you upfront.

Thank you for such informative reply, I'll fix my PR.

@fmbenhassine fmbenhassine added in: infrastructure pr-for: bug status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter labels May 26, 2020
@trapaank
Copy link
Contributor Author

I'm closing this PR in a favour of new PR as my fork master was behind from upstream master

@trapaank trapaank closed this May 26, 2020
@trapaank trapaank deleted the BATCH-3717 branch May 26, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: infrastructure pr-for: bug status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set "connectionAutoCommit" parameter with JdbcCursorItemReaderBuilder
2 participants