Skip to content

Unable to set "connectionAutoCommit" parameter with JdbcCursorItemReaderBuilder #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qwazer opened this issue May 25, 2020 · 6 comments
Closed

Unable to set "connectionAutoCommit" parameter with JdbcCursorItemReaderBuilder #3717

qwazer opened this issue May 25, 2020 · 6 comments
Assignees
@trapaank
Labels
has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" in: infrastructure type: bug
Milestone
4.3.0

Comments

@qwazer
Copy link

qwazer commented May 25, 2020 •
edited
Loading

Bug description
AbstractCursorItemReader has parameter "connectionAutoCommit" that is not configurable with JdbcCursorItemReaderBuilder

Expected behavior
"connectionAutoCommit" can be configured with JdbcCursorItemReaderBuilder

Additional info
The parameter "connectionAutoCommit" was added in #446
@qwazer qwazer added status: waiting-for-triage Issues that we did not analyse yet type: bug labels May 25, 2020
@trapaank
Copy link
Contributor

@qwazer May I please work on this issue? I have prior experience working with Spring-Batch and I would like to contribute to the project.

@fmbenhassine fmbenhassine linked a pull request May 26, 2020 that will close this issue
Added connectionAutoCommit property in JdbcCursorItemReaderBuilder #3718
Closed
@fmbenhassine fmbenhassine added in: infrastructure has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" and removed status: waiting-for-triage Issues that we did not analyse yet labels May 26, 2020
@fmbenhassine fmbenhassine added this to the 4.3.0 milestone May 26, 2020
@qwazer
Copy link
Author

qwazer commented May 26, 2020

@qwazer May I please work on this issue? I have prior experience working with Spring-Batch and I would like to contribute to the project.

H, @ankurtrapasiya Yes. Why not.

@trapaank
Copy link
Contributor

Please review #3719

@trapaank
Copy link
Contributor

@qwazer @benas - can you please review my PR?

@fmbenhassine
Copy link
Contributor

@ankurtrapasiya Thank you for your PR, I will let you know once I start looking at it. Thank you.

@trapaank trapaank mentioned this issue Jun 2, 2020
Closed
fmbenhassine pushed a commit that referenced this issue Jun 3, 2020
@trapaank @fmbenhassine
Add connectionAutoCommit property in JdbcCursorItemReaderBuilder
bbabe02 
Issue #3717
fmbenhassine pushed a commit that referenced this issue Jun 3, 2020
@trapaank @fmbenhassine
Add connectionAutoCommit property in JdbcCursorItemReaderBuilder
6052852 
Issue #3717
@fmbenhassine
Copy link
Contributor

Fixed in #3719 .

@fmbenhassine fmbenhassine changed the title Missed parameter "connectionAutoCommit" in JdbcCursorItemReaderBuilder Unable to set "connectionAutoCommit" parameter with JdbcCursorItemReaderBuilder Jun 3, 2020
This was referenced Jun 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trapaank trapaank

Labels
has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" in: infrastructure type: bug
Projects
None yet
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

Added connectionAutoCommit property in JdbcCursorItemReaderBuilder trapaank/spring-batch
3 participants
@trapaank @fmbenhassine @qwazer