Skip to content

Add connectionAutoCommit property in JdbcCursorItemReaderBuilder #3719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

trapaank
Copy link
Contributor

@trapaank trapaank commented May 26, 2020

Issue #3717

@@ -50,7 +50,7 @@ allprojects {
springVersionDefault = '5.3.0-SNAPSHOT'
springVersion = project.hasProperty('springVersion') ? getProperty('springVersion') : springVersionDefault
springRetryVersion = '1.2.5.RELEASE'
springAmqpVersion = '2.3.0.BUILD-SNAPSHOT' // TODO update to 2.3.0-SNAPSHOT when available
springAmqpVersion = '2.3.0-SNAPSHOT'
springDataCommonsVersion = '2.4.0-SNAPSHOT'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to upgrade this version because my local build was failing

* What went wrong:
Execution failed for task ':spring-batch-infrastructure:compileJava'.
> Could not resolve all files for configuration ':spring-batch-infrastructure:compileClasspath'.
   > Could not find org.springframework.amqp:spring-amqp:2.2.7.

@fmbenhassine fmbenhassine changed the title BATCH-3717(Added connectionAutoCommit property in JdbcCursorItemReade… Added connectionAutoCommit property in JdbcCursorItemReaderBuilder Jun 2, 2020
@fmbenhassine fmbenhassine added has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" in: infrastructure pr-for: bug labels Jun 2, 2020
@fmbenhassine fmbenhassine added this to the 4.3.0 milestone Jun 2, 2020
@fmbenhassine fmbenhassine changed the title Added connectionAutoCommit property in JdbcCursorItemReaderBuilder Add connectionAutoCommit property in JdbcCursorItemReaderBuilder Jun 2, 2020
@fmbenhassine
Copy link
Contributor

LGTM, rebased and merged as bbabe02. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" in: infrastructure pr-for: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants