Added AbstractCursorItemReader.connectionAutoCommit #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mminella
reviewed
Jan 9, 2017
| @@ -424,6 +444,9 @@ protected void initializeConnection() { | |||
| else { | |||
| this.con = dataSource.getConnection(); | |||
| } | |||
| if (this.connectionAutoCommit != null && this.con.getAutoCommit() != this.connectionAutoCommit) { | |||
| this.con.setAutoCommit(this.connectionAutoCommit); | |||
| } | |||
There was a problem hiding this comment.
If we allow this, we need to set it back to what it was once we're done with it.
There was a problem hiding this comment.
Thanks for the review.
I added the necessary code and amended the commit.
gdarmont
force-pushed
the
pr-cursoritemreader-autocommit
branch
3 times, most recently
from
65ce40b to
9d8e033
Compare
… of cursor connection autoCommit value autoCommit value is restored after connection use.
gdarmont
force-pushed
the
pr-cursoritemreader-autocommit
branch
from
9d8e033 to
281b387
Compare
|
Hi Spring Batch Team, Do you think there is additional work to to on this PR ? I'd be happy to help. Guillaume |
|
Rebased and merged as dca726a. Also created Jira issue BATCH-2661 for this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of discussion in PR spring-projects/spring-boot#7866
The use case was to use a JdbcCursorItemReader with PostgreSQL (nothing fancy here).
From https://jdbc.postgresql.org/documentation/94/query.html, section "Getting results based on a cursor", the connection must not be in auto commit mode.
But JdbcCursorItemReader does not allow to explicity set connection mode to autoCommit = false.
As discussed in the Spring Boot PR, configuring the JDBC pool to force all connection to autoCommit=false is not an optimal way to workaround the problem.
So here's a little PR that allows configuration of autocommit mode for the connection used by a CursorItemReader.
I validated the use of a Boolean wrapper against https://github.com/spring-projects/spring-framework/blob/master/spring-jdbc/src/main/java/org/springframework/jdbc/datasource/SingleConnectionDataSource.java#L65, to keep Spring philosophy.
Hope this helps,
Guillaume