Skip to content

Switch from FileSize to DataSize for Logback size-based properties #15930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Feb 12, 2019 · 2 comments
Closed

Switch from FileSize to DataSize for Logback size-based properties #15930

snicoll opened this issue Feb 12, 2019 · 2 comments
Assignees
@snicoll
Labels
type: enhancement A general enhancement
Milestone
2.2.0.M1

Comments

@snicoll
Copy link
Member

snicoll commented Feb 12, 2019

Follow-up of #15325

Our logging.file namespace has two properties that use FileSize behind the scenes. That object is very similar to our new DataSize support so it would be nice to expose DataSize based properties for consistency.

Unfortunately, the format is not 100% the same so we could keep binding to String and do some magic in the code? Or simply move to DataSize.
@snicoll snicoll added for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Feb 12, 2019
@snicoll snicoll added this to the 2.2.x milestone Feb 13, 2019
@nosan
Copy link
Contributor

nosan commented Feb 14, 2019

@snicoll,
I'm ready to start working on this issue, but, I have a few questions:

  • Should I change the type of these properties? (String -> DataSize)
  • Should I add support for both formats?

Thanks in advance

@snicoll
Copy link
Member Author

snicoll commented Feb 14, 2019

The purpose is to support DataSize and pass a long bytes to Logback wherever we can. I can't tell you as I haven't investigated yet.

Unfortunately, the format is not 100% the same so we could keep binding to String and do some magic in the code? Or simply move to DataSize.

The preference is to only care about DataSize but we should investigate first what happens if we use the old (String) format with it

nosan added a commit to nosan/spring-boot that referenced this issue Feb 14, 2019
@nosan
Switching from FileSize to DataSize for logback size-based properties.
5340d05 
spring-projectsgh-15930
nosan added a commit to nosan/spring-boot that referenced this issue Feb 14, 2019
@nosan
Switching from FileSize to DataSize for logback size-based properties.
c60ab7e 
spring-projectsgh-15930
@nosan nosan mentioned this issue Feb 14, 2019
Closed
nosan added a commit to nosan/spring-boot that referenced this issue Feb 16, 2019
@nosan
Switching from FileSize to DataSize for logback size-based properties.
8c51c1a 
spring-projectsgh-15930
nosan added a commit to nosan/spring-boot that referenced this issue Feb 16, 2019
@nosan
Switching from FileSize to DataSize for logback size-based properties.
8d5abd1 
spring-projectsgh-15930
nosan added a commit to nosan/spring-boot that referenced this issue Feb 18, 2019
@nosan
Switching from FileSize to DataSize for logback size-based properties.
6de5405 
spring-projectsgh-15930
@snicoll snicoll self-assigned this Feb 19, 2019
@snicoll snicoll modified the milestones: 2.2.x, 2.2.0.M1 Feb 19, 2019
@wilkinsona wilkinsona changed the title Consider switching from FileSize to DataSize for logback size-based properties Switch from FileSize to DataSize for Logback size-based properties Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.2.0.M1
Development

No branches or pull requests
2 participants
@snicoll @nosan