Switching from FileSize to DataSize for logback size-based properties.

[nosan]

see gh-15930.
DataSize can contain a negative value, Should we handle this? If yes, should we throw an exception or use a default value?
Thanks

[snicoll]

@nosan thanks for the PR. Did you check if the FileSize string format works transparently with DataSize?

[nosan]

Thanks, @snicoll
I have added some tests to check this here and here.

Current implementation parses the value via DataSize class, if something wrong, then it tries to parse a value using FileSize class.

P.S. one case which is not covered is a negative value. I think the exception should be thrown as a value is not valid.

Let me know please if I missed something.

[nosan]

FYI @snicoll,
I changed the implementation this morning and added more tests. Instead of stupid parsing via both classes, I added a regex to handle both formats.

[snicoll]

@nosan than you for the PR but I've decided to go with a different approach, see eee07ef for more details.

[nosan]

@snicoll sure, no problem.
BTW, just to make sure, you did nothing with a negative value, is it ok?

[snicoll]

I noticed your comment about that. Yes I think it is ok as the main purpose was to align tooling and size format