Skip to content

Add auto-configuration for general use TaskExecutor #5628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Apr 7, 2016

This PR adds auto-configuration for general use TaskExecutor as described in #5082.

Since Boot 1.4.0 uses Spring 4.3.0, the auto-configured TaskExecutor instance will also be picked up and used in @EnableAsync scenarios.

I'll update the documentation after the review.

  • I have signed the CLA

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 7, 2016
/**
* Maximum pool size for the executor.
*/
private Integer maxPoolSize = 10;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see a spring.task.pool.max-size in there to avoid multiple related properties in the root namespace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Apr 9, 2016
@vpavic
Copy link
Contributor Author

vpavic commented Apr 9, 2016

I've updated the PR with pool configuration properties holder, as per @snicoll's suggestion in comments.

This also resolves #1563.

@philwebb
Copy link
Member

Thanks. We're still working though some design considerations for how we'd like the TaskExecutor to work and I'm afraid It's likely that we'll want to fix this a different way.

@philwebb philwebb closed this Apr 16, 2016
@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Apr 16, 2016
@vpavic
Copy link
Contributor Author

vpavic commented Apr 16, 2016

@philwebb Thanks for the feedback. Could you share some details on the approach you'd like to take?

I've got two other PRs (#4299 and #5066) that are somewhat dependent on the availability of general TaskExecutor and would like to know what are the chances they get included in the final 1.4.0 milestone?

@philwebb
Copy link
Member

@vpavic we've not dug into the details yet I'm afraid. All we know is that we need to tread carefully and that we will need to liaise with some of the other teams (especially spring cloud).

I know that's not very helpful, but we've been burnt in the past by adding features that had knock on effects later. It may take a little time to sort this one out.

@vpavic
Copy link
Contributor Author

vpavic commented Apr 16, 2016

@philwebb Thanks for clarifying.

@philwebb philwebb removed the status: waiting-for-triage An issue we've not yet triaged label Oct 19, 2016
@vpavic vpavic deleted the gh-5082 branch August 14, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants