-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Add Quartz Scheduler support #4299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR! it looks quite complete overall. See also #3919; we could have a scheduling and async processing theme for the next version maybe... |
Scheduling/async theme sounds good. I was hoping this PR could sneak into the |
Yes, we are post RC1 now. |
Thanks for the contribution, but since there's quite a lot of code in the pull-request we'd like to wait for a while and see how much demand there is for quartz. We'll mark this one as |
+1 we use quartz all the time |
+1 , we also need quartz support |
+1, this would be very useful |
+1, would be very useful |
+1 would be very useful |
+1, I don't know any other free solution with the feature set and maturity like quartz. |
+1, adding first-class support to quartz would be very helpful when working with this framework |
Please reconsider adding this to one of Regarding the lot of code argument, IMO implementation is pretty straightforward and it is based on Quartz support in the core Spring Framework, test coverage is good, sample app and documentation are also in the mix so it shouldn't be a risky addition. If this is added to the upcoming milestones, I can rebase onto current master and update the PR to fix the conflicts. |
Well IMO, that's exactly the problem. It is a one-to-one mapping for what the I am not denying that having some kind of scheduling solution in Spring Boot is interesting but I'd rather focus on the 80% use cases first. And this PR doesn't do that. Maybe those who voted could share their most frequent use case and we could try to derive a proper default behaviour from that? |
@snicoll I'm confused by your comment. Auto-configuration for |
I guess what I tried to say is that it maps all the features of the |
OK, I'm open to suggestions. Persistent As far as configuration properties are concerned, we regulary use |
2416da6
to
f6e0f2c
Compare
I've updated the PR with following changes:
@snicoll, @philwebb, please review the changes, I'm looking forward to your feedback. |
Also this PR is another use case which would benefit from #5082. |
👍 |
f6e0f2c
to
82ab523
Compare
+1 |
82ab523
to
10cbae2
Compare
Any feedback on the latest changes? |
+1 |
1 similar comment
+1 |
+1 quartz + (proper) cluster exec it's crucial item for my microservice architecture. |
8292a96
to
1649d5b
Compare
+1 |
No more +1's please :) We're going to try and get this into Boot 2.0 |
Quartz Scheduler This release will include Quartz database schema scripts as a part of |
This project: https://github.com/FlavioF/quartz-scheduler-hazelcast-jobstore |
1649d5b
to
4666702
Compare
PR updated to align with newly released Quartz |
f22054e
to
940eacd
Compare
As stated here: https://github.com/spring-projects/spring-boot/pull/4299/files?diff=unified#r118478148 current solution disallow using constructor injection (and possibly more things - aspects etc.) in Quartz job. |
940eacd
to
9d04ce2
Compare
* pr/4299: Polish "Add Quartz Scheduler support" Add Quartz Scheduler support
Spring Framework has had Quartz Scheduler support for a very long time - it would be nice to make use of it in Spring Boot.
This PR adds:
SchedulerFactoryBean
spring-boot-starter-quartz
spring-boot-sample-quartz
Please review, comments are welcome.
If this PR is accepted I'd also like to add Actuator support in a separate PR.
I've signed the CLA.