Add influxDB java client auto-configuration #9066
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
the
for: team-attention
|
@kuptservol What's your motivation for having auto-configuration for InfluxDB's client? It feels a bit strange to have it without also integrating with Actuator's Metrics (#5688). |
wilkinsona
added
the
status: waiting-for-feedback
|
@wilkinsona The motivation is to have configuration for InfluxDB as engine for metrics and events itself, not integrated with any existing metrics library. I suppose that db client must not be coupled tightly to some of it's clients(Actuator's Metrics f.e.) cause it's narrowing the usage of DB client - and there are much more usage scenarios of InfluxDb client. - F.e. in my project i have my own application metrics lib and i decided to log them to Influx - this pr decreasing configuration for db client. |
philwebb
added
priority: normal
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Jun 2, 2017
snicoll
added a commit
that referenced
this pull request
Jun 2, 2017
* pr/9066: Polish "Add influxDB java client auto-configuration" Add influxDB java client auto-configuration
wilkinsona
added a commit
that referenced
this pull request
Jun 2, 2017
snicoll
added a commit
that referenced
this pull request
Jun 5, 2017
This commit removes the `client` namespace for InfluxDB as the component that is created is `InfluxDB`, not `InfluxDBClient` or something. This aligns with all the other url/user/password properties Spring Boot provides already See gh-9066
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to autoconfigure influxDB java client.